Open
Conversation
Opens a props dialog when running SuggestShadeFromExternalStyle, exposing a Value offset (-1 to +1) and Saturation factor (0 to 2) that are applied in HSV space before writing the IFC surface colour. Generated with the assistance of an AI coding tool.
…xternal styles as well and set active based on toggle. We only travers teh files once and apply to all materials that share the style. Now we can have pretty mode as default :)
Switching to External style had no visible effect because switch_shading used a fast-path that only flipped is_active_output on the dual-branch nodes. This was a no-op when BIM_Output_External was already active, and material.update_tag() alone was insufficient to trigger a viewport redraw regardless. Fix by always calling activate_external_style for the External case, which re-loads the .blend material and goes through Blender's operator path that reliably refreshes the viewport. Generated with the assistance of an AI coding tool. AI effort: 4/10
Member
|
I figured i'd just push this fix to your branch, although it's bug on v0.8.0 :) |
…al-viewport Fix IfcOpenShell#7990 - Fix update_current_style not refreshing viewport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a simple toggle to get either pretty styles based on external files (texture or .blend, UV, shaders.) or flat rendering based on Ifc simpler approach.
Kooha-2026-04-15-12-53-30.mp4
Cheers!