Remove additional fuzz markup on halfspace operands and initially process with smaller fuzz. Fixes #601

aothms · aothms · commit f5b7d0db5907 · 2019-06-05T16:58:08.000+02:00
diff --git a/src/ifcgeom/IfcGeomFunctions.cpp b/src/ifcgeom/IfcGeomFunctions.cpp
@@ -3938,7 +3938,7 @@ bool IfcGeom::Kernel::boolean_operation(const TopoDS_Shape& a, const TopoDS_Shap
 bool IfcGeom::Kernel::boolean_operation(const TopoDS_Shape& a_, const TopTools_ListOfShape& b__, BOPAlgo_Operation op, TopoDS_Shape& result, double fuzziness) {
 	
 	if (fuzziness < 0.) {
-		fuzziness = getValue(GV_PRECISION);
+		fuzziness = getValue(GV_PRECISION) / 10.;
 	}
 
 	// @todo, it does seem a bit odd, we first triangulate non-planar faces
diff --git a/src/ifcgeom/IfcGeomShapes.cpp b/src/ifcgeom/IfcGeomShapes.cpp
@@ -609,8 +609,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcBooleanResult* l, TopoDS_Shape
 #if OCC_VERSION_HEX < 0x60900
 	bool valid_result = boolean_operation(s1, s2, occ_op, shape);
 #else
-	const double fuzz = has_halfspace_operand ? getValue(GV_PRECISION) * 10. : -1.;
-	bool valid_result = boolean_operation(s1, second_operand_shapes, occ_op, shape, fuzz);
+	bool valid_result = boolean_operation(s1, second_operand_shapes, occ_op, shape);
 #endif
 
 	if (op == IfcSchema::IfcBooleanOperator::IfcBooleanOperator_DIFFERENCE) {

Original file line number	Diff line number	Diff line change
`@@ -3938,7 +3938,7 @@ bool IfcGeom::Kernel::boolean_operation(const TopoDS_Shape& a, const TopoDS_Shap`
`3938`	`3938`	`bool IfcGeom::Kernel::boolean_operation(const TopoDS_Shape& a_, const TopTools_ListOfShape& b__, BOPAlgo_Operation op, TopoDS_Shape& result, double fuzziness) {`
`3939`	`3939`
`3940`	`3940`	`if (fuzziness < 0.) {`
`3941`		`- fuzziness = getValue(GV_PRECISION);`
	`3941`	`+ fuzziness = getValue(GV_PRECISION) / 10.;`
`3942`	`3942`	`}`
`3943`	`3943`
`3944`	`3944`	`// @todo, it does seem a bit odd, we first triangulate non-planar faces`