Simplify destructor by removing null check #7650

aothms · web-flow · commit f5686fff2619 · 2026-02-10T09:25:02.000+01:00
diff --git a/src/ifcgeom/Converter.cpp b/src/ifcgeom/Converter.cpp
@@ -12,11 +12,8 @@ ifcopenshell::geometry::Converter::Converter(std::unique_ptr<ifcopenshell::geome
 	settings_ = mapping_->settings();
 }
 
-ifcopenshell::geometry::Converter::~Converter()
-{
-	if (mapping_ != nullptr) {
-		delete mapping_;
-	}
+ifcopenshell::geometry::Converter::~Converter() {
+    delete mapping_;
 }
 
 namespace {

Original file line number	Diff line number	Diff line change
`@@ -12,11 +12,8 @@ ifcopenshell::geometry::Converter::Converter(std::unique_ptr<ifcopenshell::geome`
`12`	`12`	`settings_ = mapping_->settings();`
`13`	`13`	`}`
`14`	`14`
`15`		`-ifcopenshell::geometry::Converter::~Converter()`
`16`		`-{`
`17`		`- if (mapping_ != nullptr) {`
`18`		`- delete mapping_;`
`19`		`- }`
	`15`	`+ifcopenshell::geometry::Converter::~Converter() {`
	`16`	`+ delete mapping_;`
`20`	`17`	`}`
`21`	`18`
`22`	`19`	`namespace {`