Propagate unit settings

aothms · aothms · commit efd05158c456 · 2024-12-01T11:21:15.000+01:00
diff --git a/src/ifcgeom/Converter.cpp b/src/ifcgeom/Converter.cpp
@@ -6,10 +6,11 @@ using namespace ifcopenshell::geometry;
 
 ifcopenshell::geometry::Converter::Converter(const std::string& geometry_library, IfcParse::IfcFile* file, ifcopenshell::geometry::Settings& s)
 	: geometry_library_(boost::to_lower_copy(geometry_library))
-	, settings_(s)
 {
-	mapping_ = impl::mapping_implementations().construct(file, settings_);
+	mapping_ = impl::mapping_implementations().construct(file, s);
 	kernel_ = kernels::construct(file, geometry_library, mapping_->settings());
+	// Mapping reads unit information and applies to settings
+	settings_ = mapping_->settings();
 }
 
 namespace {

Original file line number	Diff line number	Diff line change
`@@ -6,10 +6,11 @@ using namespace ifcopenshell::geometry;`
`6`	`6`
`7`	`7`	`ifcopenshell::geometry::Converter::Converter(const std::string& geometry_library, IfcParse::IfcFile* file, ifcopenshell::geometry::Settings& s)`
`8`	`8`	`: geometry_library_(boost::to_lower_copy(geometry_library))`
`9`		`- , settings_(s)`
`10`	`9`	`{`
`11`		`- mapping_ = impl::mapping_implementations().construct(file, settings_);`
	`10`	`+ mapping_ = impl::mapping_implementations().construct(file, s);`
`12`	`11`	`kernel_ = kernels::construct(file, geometry_library, mapping_->settings());`
	`12`	`+ // Mapping reads unit information and applies to settings`
	`13`	`+ settings_ = mapping_->settings();`
`13`	`14`	`}`
`14`	`15`
`15`	`16`	`namespace {`