Skip to content

Commit ed8a31c

Browse files
committed
Update ignored settings structs in IfcPython.i #6976
1 parent 3d30d80 commit ed8a31c

3 files changed

Lines changed: 21 additions & 29 deletions

File tree

src/ifcopenshell-python/ifcopenshell/ifcopenshell_wrapper.pyi

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,6 @@ class BRepElement(Element):
135135
@property
136136
def volume(self): ...
137137

138-
class CgalEmitOriginalEdges:
139-
name: Any
140-
description: Any
141-
defaultvalue: Any
142-
143138
class ColladaSerializer(WriteOnlyGeometrySerializer):
144139
def finalize(self): ...
145140
def isTesselated(self): ...
@@ -150,11 +145,6 @@ class ColladaSerializer(WriteOnlyGeometrySerializer):
150145
def write(self, *args): ...
151146
def writeHeader(self): ...
152147

153-
class ComputeCurvature:
154-
name: Any
155-
description: Any
156-
defaultvalue: Any
157-
158148
class ConversionResult:
159149
def ItemId(self): ...
160150
def Placement(self): ...
@@ -273,16 +263,6 @@ class Element:
273263
class FileSchema(HeaderEntity):
274264
schema_identifiers: Any
275265

276-
class FunctionStepParam:
277-
name: Any
278-
description: Any
279-
defaultvalue: Any
280-
281-
class FunctionStepType:
282-
name: Any
283-
description: Any
284-
defaultvalue: Any
285-
286266
class GeometrySerializer:
287267
READ_BREP: Any
288268
READ_TRIANGULATION: Any
@@ -566,11 +546,6 @@ class TriangulationElement(Element):
566546
def geometry(self) -> Triangulation: ...
567547
def geometry_pointer(self): ...
568548

569-
class TriangulationType:
570-
name: Any
571-
description: Any
572-
defaultvalue: Any
573-
574549
class TtlWktSerializer(WriteOnlyGeometrySerializer):
575550
def finalize(self): ...
576551
def isTesselated(self): ...

src/ifcopenshell-python/test/test_create_shape.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
class TestGeomSettings:
1717
def test_settings(self):
1818
settings = ifcopenshell.geom.settings()
19-
assert set(get_args(ifcopenshell.geom.SETTING)) == set(settings.setting_names())
19+
assert set(get_args(ifcopenshell.geom.SETTING)) == set(
20+
settings.setting_names()
21+
), "Also need to update IfcPython.i, if new settings were added/removed."
2022

2123
assert "use-python-opencascade" in settings.setting_names()
2224
assert settings.get(settings.USE_PYTHON_OPENCASCADE) is False
@@ -38,7 +40,9 @@ def test_settings(self):
3840

3941
def test_serializer_settings(self):
4042
settings = ifcopenshell.geom.serializer_settings()
41-
assert set(get_args(ifcopenshell.geom.SERIALIZER_SETTING)) == set(settings.setting_names())
43+
assert set(get_args(ifcopenshell.geom.SERIALIZER_SETTING)) == set(
44+
settings.setting_names()
45+
), "Also need to update IfcPython.i, if new settings were added/removed."
4246

4347
# Only for settings.
4448
assert "use-python-opencascade" not in settings.setting_names()

src/ifcwrap/IfcPython.i

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@
9494
%ignore loop_to_function_item_upgrade_impl;
9595

9696
// settings, can this done more generally?
97+
// GeometrySerializer.h
9798
%ignore UseElementNames;
9899
%ignore UseElementGuids;
99100
%ignore UseElementStepIds;
@@ -103,6 +104,7 @@
103104
%ignore FloatingPointDigits;
104105
%ignore BaseUri;
105106
%ignore WktUseSection;
107+
// ConversionSettings.h
106108
%ignore MesherLinearDeflection;
107109
%ignore MesherAngularDeflection;
108110
%ignore ReorientShells;
@@ -137,14 +139,25 @@
137139
%ignore SiteLocalPlacement;
138140
%ignore BuildingLocalPlacement;
139141
%ignore NoParallelMapping;
142+
%ignore PermissiveShapeReuse;
140143
%ignore ForceSpaceTransparency;
141144
%ignore CircleSegments;
145+
%ignore CgalSmoothAngleDegrees;
142146
%ignore KeepBoundingBoxes;
143147
%ignore SurfaceColour;
144-
%ignore PiecewiseStepType;
145-
%ignore PiecewiseStepParam;
148+
%ignore ComputeCurvature;
149+
%ignore FunctionStepType;
150+
%ignore FunctionStepParam;
146151
%ignore ModelOffset;
147152
%ignore ModelRotation;
153+
%ignore TriangulationType;
154+
%ignore CgalEmitOriginalEdges;
155+
%ignore OcctNoCleanTriangulation;
156+
%ignore CacheShapes;
157+
%ignore DeferProcessingFirstElement;
158+
%ignore MaxOffset;
159+
%ignore MaxOffsetDeviation;
160+
%ignore ApplyOffset;
148161

149162
// Triangulated representation helper struct
150163
%ignore EdgeKey;

0 commit comments

Comments
 (0)