ifccityjson: lazy build vertex dictionary

LaurensJN · LaurensJN · commit dd348de0b75f · 2021-11-07T10:40:01.000+01:00
diff --git a/src/ifccityjson/cityjson2ifc.py b/src/ifccityjson/cityjson2ifc.py
@@ -84,9 +84,10 @@ def convert(self, city_model):
         self.city_model = city_model
         self.create_new_file()
         self.create_metadata()
-        self.geometry.build_vertices(self.IFC_model,
-                                     coords=city_model.j["vertices"],
-                                     scale=self.properties["local_scale"])
+        self.geometry.set_scale(self.properties["local_scale"])
+        #self.geometry.build_vertices(self.IFC_model,
+        #                             coords=city_model.j["vertices"],
+        #                             scale=self.properties["local_scale"])
         # self.build_vertices()
         self.create_IFC_classes()
         if self.properties["split"]:
diff --git a/src/ifccityjson/geometry.py b/src/ifccityjson/geometry.py
@@ -20,20 +20,34 @@
 import warnings
 
 class GeometryIO:
-    def __init__(self):
+    def __init__(self, scale=None):
         self.vertices = {}
+        self.scale = scale
 
-    def build_vertices(self, IFC_model, coords, scale=None):
-        for coord in coords:
-            if scale:
-                IFC_vertex = tuple([float(xyz) * coord_scale
-                                    for xyz, coord_scale
-                                    in zip(coord, scale)])
-            else:
-                IFC_vertex = [float(xyz) for xyz in coord]
+    def set_scale(self, scale):
+        self.scale = scale
 
-            IFC_cartesian_point = IFC_model.create_entity("IfcCartesianPoint", IFC_vertex)
-            self.vertices[tuple(coord)] = IFC_cartesian_point
+    def build_vertices(self, IFC_model, vertices):
+        for vertex in vertices:
+            self.build_vertex(self, IFC_model, vertex)
+
+    def build_vertex(self, IFC_model, vertex):
+        if self.scale:
+            IFC_vertex = [float(xyz) * coord_scale
+                                for xyz, coord_scale
+                                in zip(vertex, self.scale)]
+        else:
+            IFC_vertex = [float(xyz) for xyz in vertex]
+
+        IFC_cartesian_point = IFC_model.create_entity("IfcCartesianPoint", IFC_vertex)
+        self.vertices[tuple(vertex)] = IFC_cartesian_point
+        return IFC_cartesian_point
+
+    def get_vertex(self, IFC_model, vertex):
+        if tuple(vertex) in self.vertices:
+            return self.vertices[tuple(vertex)]
+        else:
+            return self.build_vertex(IFC_model, vertex)
 
     # See for CityJSON geometries:
     # https://www.cityjson.org/dev/geom-arrays/
@@ -75,7 +89,7 @@ def create_IFC_composite_curve(self, IFC_model, geometry):
         for line in geometry.boundaries:
             vertices = []
             for vertex in line:
-                vertices.append(self.vertices[tuple(vertex)])
+                vertices.append(self.get_vertex(IFC_model, vertex))
             polyline = IFC_model.create_entity("IfcPolyLine", vertices)
             IFC_geometry.append(polyline)
         return IFC_geometry
@@ -133,9 +147,9 @@ def create_IFC_face(self, IFC_model, face):
         # exterior face
         vertices = []
         for vertex in face[0]:
-            vertices.append(self.vertices[tuple(vertex)])
         polyloop = IFC_model.create_entity("IfcPolyLoop", vertices)
         outerbound = IFC_model.create_entity("IfcFaceOuterBound", polyloop, True)
+            vertices.append(self.get_vertex(IFC_model, vertex))
 
         # return if only exterior face
         if len(face) == 1:
@@ -145,8 +159,8 @@ def create_IFC_face(self, IFC_model, face):
         innerbounds = []
         for interior_face in face[1:]:
             for vertex in interior_face:
-                vertices.append(self.vertices[tuple(vertex)])
             polyloop = IFC_model.create_entity("IfcPolyLoop", vertices)
             innerbounds.append(IFC_model.create_entity("IfcFaceBound", polyloop, True))
         return IFC_model.create_entity("IfcFace", [outerbound] + innerbounds)
 
+                vertices.append(self.get_vertex(IFC_model, vertex))
