fix: memory leak from missing deletes of raw heap allocations; big issue within create_shape() python lib

shmoodyyy · aothms · commit c6e3ac4155da · 2025-03-24T13:59:58.000+01:00
diff --git a/src/ifcgeom/AbstractKernel.cpp b/src/ifcgeom/AbstractKernel.cpp
@@ -206,6 +206,8 @@ ifcopenshell::geometry::kernels::AbstractKernel* ifcopenshell::geometry::kernels
 			}
 #endif
 			if (kernels.size() != n + 1) {
+                for (auto k : kernels)
+                    delete k;
 				throw IfcParse::IfcException("Invalid hybrid kernel " + geometry_library);
 			}
 		}
diff --git a/src/ifcgeom/Converter.cpp b/src/ifcgeom/Converter.cpp
@@ -13,6 +13,16 @@ ifcopenshell::geometry::Converter::Converter(const std::string& geometry_library
 	settings_ = mapping_->settings();
 }
 
+ifcopenshell::geometry::Converter::~Converter()
+{
+    if (kernel_ != nullptr) {
+        delete kernel_;
+    }
+    if (mapping_ != nullptr) {
+        delete mapping_;
+    }
+}
+
 namespace {
 	void substitute_with_box_based_on_density(IfcGeom::ConversionResults& items, double& density) {
 		int nv = 0;
diff --git a/src/ifcgeom/Converter.h b/src/ifcgeom/Converter.h
@@ -28,7 +28,7 @@ namespace ifcopenshell { namespace geometry {
 
 		Converter(const std::string& geometry_library, IfcParse::IfcFile* file, ifcopenshell::geometry::Settings& settings);
 		
-		~Converter() {}
+		~Converter();
 
 		ifcopenshell::geometry::abstract_mapping* mapping() const { return mapping_; }
 
diff --git a/src/ifcgeom/kernels/opencascade/boolean_utils.cpp b/src/ifcgeom/kernels/opencascade/boolean_utils.cpp
@@ -978,6 +978,7 @@ bool IfcGeom::util::boolean_operation(const boolean_settings& settings, const To
 	if (b.Extent() == 0) {
 		Logger::Warning("No other operands remaining, using first operand");
 		result = a;
+        delete builder;
 		return true;
 	}
 
@@ -1130,6 +1131,7 @@ bool IfcGeom::util::boolean_operation(const boolean_settings& settings, const To
 						} else {
 							Logger::Notice("Processed fully in 2D");
 							result = mp.Shape();
+                            delete builder;
 							return true;
 						}
 					} else {

Original file line number	Diff line number	Diff line change
`@@ -206,6 +206,8 @@ ifcopenshell::geometry::kernels::AbstractKernel* ifcopenshell::geometry::kernels`
`206`	`206`	`}`
`207`	`207`	`#endif`
`208`	`208`	`if (kernels.size() != n + 1) {`
	`209`	`+ for (auto k : kernels)`
	`210`	`+ delete k;`
`209`	`211`	`throw IfcParse::IfcException("Invalid hybrid kernel " + geometry_library);`
`210`	`212`	`}`
`211`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -978,6 +978,7 @@ bool IfcGeom::util::boolean_operation(const boolean_settings& settings, const To`
`978`	`978`	`if (b.Extent() == 0) {`
`979`	`979`	`Logger::Warning("No other operands remaining, using first operand");`
`980`	`980`	`result = a;`
	`981`	`+ delete builder;`
`981`	`982`	`return true;`
`982`	`983`	`}`
`983`	`984`
`@@ -1130,6 +1131,7 @@ bool IfcGeom::util::boolean_operation(const boolean_settings& settings, const To`
`1130`	`1131`	`} else {`
`1131`	`1132`	`Logger::Notice("Processed fully in 2D");`
`1132`	`1133`	`result = mp.Shape();`
	`1134`	`+ delete builder;`
`1133`	`1135`	`return true;`
`1134`	`1136`	`}`
`1135`	`1137`	`} else {`