Support single circ/elip compcurves #7149

aothms · aothms · commit b6abb24858e9 · 2025-09-23T11:11:42.000+02:00
diff --git a/src/ifcgeom/mapping/IfcCompositeCurve.cpp b/src/ifcgeom/mapping/IfcCompositeCurve.cpp
@@ -58,11 +58,20 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcCompositeCurve* inst) {
 				if (crv->kind() == taxonomy::EDGE) {
 					auto ecrv = taxonomy::cast<taxonomy::edge>(crv);
 					loop->children.push_back(ecrv);
-				}
-				else if (crv->kind() == taxonomy::LOOP) {
+				} else if (crv->kind() == taxonomy::LOOP) {
 					for (auto& s : taxonomy::cast<taxonomy::loop>(crv)->children) {
 						loop->children.push_back(s);
 					}
+				} else if ((crv->kind() == taxonomy::CIRCLE || crv->kind() == taxonomy::ELLIPSE) && segments->size() == 1) {
+					// A circle or ellipse segment is a full circle/ellipse, only possible when it is the only segment
+					std::shared_ptr<taxonomy::edge> e = std::make_shared<taxonomy::edge>();
+					e->basis = crv;
+					e->start = 0.0;
+					e->end = 2.0 * boost::math::constants::pi<double>();
+					loop->children.push_back(e);
+				} else {
+					Logger::Warning("Unexpected segment type", segment);
+					return nullptr;
 				}
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -58,11 +58,20 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcCompositeCurve* inst) {`
`58`	`58`	`if (crv->kind() == taxonomy::EDGE) {`
`59`	`59`	`auto ecrv = taxonomy::cast<taxonomy::edge>(crv);`
`60`	`60`	`loop->children.push_back(ecrv);`
`61`		`- }`
`62`		`- else if (crv->kind() == taxonomy::LOOP) {`
	`61`	`+ } else if (crv->kind() == taxonomy::LOOP) {`
`63`	`62`	`for (auto& s : taxonomy::cast<taxonomy::loop>(crv)->children) {`
`64`	`63`	`loop->children.push_back(s);`
`65`	`64`	`}`
	`65`	`+ } else if ((crv->kind() == taxonomy::CIRCLE \|\| crv->kind() == taxonomy::ELLIPSE) && segments->size() == 1) {`
	`66`	`+ // A circle or ellipse segment is a full circle/ellipse, only possible when it is the only segment`
	`67`	`+ std::shared_ptr<taxonomy::edge> e = std::make_shared<taxonomy::edge>();`
	`68`	`+ e->basis = crv;`
	`69`	`+ e->start = 0.0;`
	`70`	`+ e->end = 2.0 * boost::math::constants::pi<double>();`
	`71`	`+ loop->children.push_back(e);`
	`72`	`+ } else {`
	`73`	`+ Logger::Warning("Unexpected segment type", segment);`
	`74`	`+ return nullptr;`
`66`	`75`	`}`
`67`	`76`	`}`
`68`	`77`	`}`