build_pyodide.yaml - move build_pyodide to a separate script

Andrej730 · Andrej730 · commit aee8cbe47967 · 2025-10-28T17:17:18.000+05:00
diff --git a/.github/workflows/build_pyodide.yml b/.github/workflows/build_pyodide.yml
@@ -28,18 +28,8 @@ jobs:
           VERSION=`cat IfcOpenShell/VERSION`
           sed -i s/0.8.0/$VERSION/g IfcOpenShell/pyodide/meta.yaml
           sed -i s/0.8.0/$VERSION/g IfcOpenShell/pyodide/setup.py
-          echo '#!/usr/bin/bash' > script.sh
-          echo 'cd pyodide' >> script.sh
-          echo 'make' >> script.sh
-          echo 'cd ..' >> script.sh
-          echo 'mkdir -p packages/ifcopenshell' >> script.sh
-          echo 'cp IfcOpenShell/pyodide/meta.yaml packages/ifcopenshell' >> script.sh
-          echo 'PYODIDE_ROOT=/src/pyodide \' >> script.sh
-          echo 'PATH=/src/pyodide/emsdk/emsdk:/src/pyodide/emsdk/emsdk/node/22.16.0_64bit/bin:/src/pyodide/emsdk/emsdk/upstream/emscripten:$PATH \' >> script.sh
-          echo 'pyodide build-recipes ifcopenshell --install' >> script.sh
-          chmod +x script.sh
           sed -i s/--tty// pyodide/run_docker
-          pyodide/run_docker ./script.sh
+          pyodide/run_docker IfcOpenShell/pyodide/build_pyodide.sh
           FILE=`echo dist/ifcopenshell-*.whl`
           NEW_FILE=`echo $FILE | sed "s/$VERSION/$VERSION+${GITHUB_SHA:0:7}/"`
           mv $FILE $NEW_FILE
diff --git a/pyodide/build_pyodide.sh b/pyodide/build_pyodide.sh
@@ -0,0 +1,12 @@
+#!/usr/bin/bash
+set -e
+cd pyodide
+make
+cd ..
+mkdir -p packages/ifcopenshell
+cp IfcOpenShell/pyodide/meta.yaml packages/ifcopenshell
+# Required, otherwise pyodide will create new temp pyodide environment.
+export PYODIDE_ROOT=/src/pyodide
+# Ensure emsdk tools are in PATH.
+export PATH=$PYODIDE_ROOT/emsdk/emsdk:$PYODIDE_ROOT/emsdk/emsdk/node/22.16.0_64bit/bin:$PYODIDE_ROOT/emsdk/emsdk/upstream/emscripten:$PATH
+pyodide build-recipes ifcopenshell --install
diff --git a/win/build-all-win.py b/win/build-all-win.py
@@ -48,6 +48,7 @@ def build() -> None:
                 "-DGLTF_SUPPORT=ON",
                 "-DADD_COMMIT_SHA=ON",
                 "-DVERSION_OVERRIDE=ON",
+                "-DSCHEMA_VERSIONS=4",
             ]
         )
         run([str(REPO_WIN / "install-ifcopenshell.bat"), "vs2022-x64", "Release"])

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ def build() -> None:`
`48`	`48`	`"-DGLTF_SUPPORT=ON",`
`49`	`49`	`"-DADD_COMMIT_SHA=ON",`
`50`	`50`	`"-DVERSION_OVERRIDE=ON",`
	`51`	`+ "-DSCHEMA_VERSIONS=4",`
`51`	`52`	`]`
`52`	`53`	`)`
`53`	`54`	`run([str(REPO_WIN / "install-ifcopenshell.bat"), "vs2022-x64", "Release"])`