Fix failing inverse test

aothms · aothms · commit a65fa1e6067c · 2025-08-28T09:37:09.000+02:00
diff --git a/src/ifcparse/IfcParse.cpp b/src/ifcparse/IfcParse.cpp
@@ -2049,12 +2049,12 @@ IfcUtil::IfcBaseClass* IfcFile::addEntity(IfcUtil::IfcBaseClass* entity, int id)
         }, storage_);
     }
 
-    /*
-    // @todo not needed anymore, because these are now calculated by using baseclass::set() ?
+    // @todo verify whether this is still needed. If instances are created directly on the file
+    // with create() (which is a necessity for using rocksdb storage) then it should be sufficient
+    // to register inverses only on attribute updates.
     if ((ty->as_entity() != nullptr)) {
         build_inverses_(new_entity);
     }
-    */
 
     return new_entity;
 }

Original file line number	Diff line number	Diff line change
`@@ -2049,12 +2049,12 @@ IfcUtil::IfcBaseClass* IfcFile::addEntity(IfcUtil::IfcBaseClass* entity, int id)`
`2049`	`2049`	`}, storage_);`
`2050`	`2050`	`}`
`2051`	`2051`
`2052`		`- /*`
`2053`		`- // @todo not needed anymore, because these are now calculated by using baseclass::set() ?`
	`2052`	`+ // @todo verify whether this is still needed. If instances are created directly on the file`
	`2053`	`+ // with create() (which is a necessity for using rocksdb storage) then it should be sufficient`
	`2054`	`+ // to register inverses only on attribute updates.`
`2054`	`2055`	`if ((ty->as_entity() != nullptr)) {`
`2055`	`2056`	`build_inverses_(new_entity);`
`2056`	`2057`	`}`
`2057`		`- */`
`2058`	`2058`
`2059`	`2059`	`return new_entity;`
`2060`	`2060`	`}`