Skip to content

Commit 9d42f4c

Browse files
committed
Update Bonsai to latest ifcmerge (#7581 #3096)
This version has some functional differences: - Structured JSON error message instead of free text (on STDOUT not STDERR) - New --prioritise-local flag to control which side wins in merge conflicts (not used by Bonsai yet) - IfcLocalPlacement conflicts now auto-resolve instead of failing the merge (partial solution to #6885) - Float values are normalised when comparing entities (workaround for #7696)
1 parent fdb2947 commit 9d42f4c

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/bonsai/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ PYNUMBER:=3$(PYMINOR)
6464
PYPI_VERSION:=3.$(PYMINOR)
6565
endif # def PYVERSION
6666

67+
IFCMERGE_VERSION:=2026-04-02
6768

6869
ifdef PLATFORM
6970
SUPPORTED_PLATFORMS := linux macos macosm1 win
@@ -240,10 +241,9 @@ endif
240241

241242
# required for three-way git merging
242243
ifeq ($(PLATFORM), win)
243-
cd build/bonsai/libs/bin && wget https://github.com/brunopostle/ifcmerge/releases/download/2025-01-26/ifcmerge.zip
244-
cd build/bonsai/libs/bin && unzip ifcmerge.zip && rm ifcmerge.zip
244+
cd build/bonsai/libs/bin && wget https://github.com/brunopostle/ifcmerge/releases/download/$(IFCMERGE_VERSION)/ifcmerge.exe
245245
else
246-
cd build/bonsai/libs/bin && wget https://raw.githubusercontent.com/brunopostle/ifcmerge/main/ifcmerge && chmod +x ifcmerge
246+
cd build/bonsai/libs/bin && wget https://raw.githubusercontent.com/brunopostle/ifcmerge/$(IFCMERGE_VERSION)/ifcmerge && chmod +x ifcmerge
247247
endif
248248

249249
# Generate translations module for Bonsai build

src/bonsai/bonsai/tool/ifcgit.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ def git_mergetool(cls, mergetool: str) -> Union[str, None]:
546546
repo.git.mergetool(tool=mergetool)
547547
return None
548548
except git.exc.GitCommandError as exc:
549-
return re.sub("( stderr: '|')", "", exc.stderr)
549+
return re.sub("( stdout: '|')", "", exc.stdout)
550550

551551
@classmethod
552552
def git_merge_abort(cls) -> None:

0 commit comments

Comments
 (0)