Update IfcTester to support changed upstream spec where prohibited specs cannot have requirements.

Moult · Moult · commit 6da51c2a6e02 · 2025-09-30T00:05:57.000+10:00
diff --git a/src/ifctester/ifctester/facet.py b/src/ifctester/ifctester/facet.py
@@ -136,6 +136,7 @@ def to_string(
             elif requirement.cardinality == "prohibited":
                 templates = self.prohibited_templates
             elif requirement.cardinality == "optional":
+                templates = self.requirement_templates
                 templates = [
                     t.replace("shall", "may").replace("Shall", "May").replace("must", "may") for t in templates
                 ]
diff --git a/src/ifctester/test/test_ids.py b/src/ifctester/test/test_ids.py
@@ -170,29 +170,34 @@ def test_creating_a_minimal_ids_and_validating(self):
         waldo = model.createIfcSlab(Name="Waldo")
         run("Optional specifications may still pass if nothing is applicable", specs, model, True)
 
+        specs = ids.Ids(title="Title")
+        spec = ids.Specification(name="Name")
+        spec.applicability.append(ids.Entity(name="IFCWALL"))
+        spec.applicability.append(ids.Attribute(name="Name", value="Waldo"))
+        specs.specifications.append(spec)
         spec.set_usage("prohibited")
         model = ifcopenshell.file()
         wall = model.createIfcSlab(Name="Waldo")
-        run("Prohibited specifications fail if at least one entity passes all requirements 1/3", specs, model, True)
+        run("Prohibited specifications fail if at least one entity is applicable 1/3", specs, model, True)
         model = ifcopenshell.file()
         wall = model.createIfcWall(Name="Wally")
         run(
-            "Prohibited specifications fail if at least one entity passes all requirements 2/3",
+            "Prohibited specifications fail if at least one entity is applicable 2/3",
             specs,
             model,
             True,
-            [wall],
+            [],
             [],
         )
         model = ifcopenshell.file()
         wall = model.createIfcWall(Name="Waldo")
         run(
-            "Prohibited specifications fail if at least one entity passes all requirements 3/3",
+            "Prohibited specifications fail if at least one entity is applicable 3/3",
             specs,
             model,
             False,
             [wall],
-            [wall],
+            [],
         )
 
         spec.set_usage("optional")

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,7 @@ def to_string(`
`136`	`136`	`elif requirement.cardinality == "prohibited":`
`137`	`137`	`templates = self.prohibited_templates`
`138`	`138`	`elif requirement.cardinality == "optional":`
	`139`	`+ templates = self.requirement_templates`
`139`	`140`	`templates = [`
`140`	`141`	`t.replace("shall", "may").replace("Shall", "May").replace("must", "may") for t in templates`
`141`	`142`	`]`