fixed bug removing representation item

Andrej730 · Andrej730 · commit 6d7a6eeda740 · 2024-02-02T14:53:10.000+05:00
if you'd click on "remove item" button for some item it wouldn't remove the corresponding item but would go for removing active item instead
diff --git a/src/blenderbim/blenderbim/bim/module/geometry/operator.py b/src/blenderbim/blenderbim/bim/module/geometry/operator.py
@@ -1614,6 +1614,8 @@ class RemoveRepresentationItem(bpy.types.Operator, Operator):
     bl_label = "Remove Representation Item"
     bl_options = {"REGISTER", "UNDO"}
 
+    representation_item_id: bpy.props.IntProperty()
+
     @classmethod
     def poll(cls, context):
         if context.active_object is None or len(context.active_object.BIMGeometryProperties.items) <= 1:
@@ -1628,8 +1630,7 @@ def _execute(self, context):
         props = obj.BIMGeometryProperties
         ifc_file = tool.Ifc.get()
 
-        representation_item_id = props.items[props.active_item_index].ifc_definition_id
-        representation_item = ifc_file.by_id(representation_item_id)
+        representation_item = ifc_file.by_id(self.representation_item_id)
         tool.Geometry.remove_representation_item(representation_item)
         tool.Geometry.reload_representation(obj)
 
diff --git a/src/blenderbim/blenderbim/bim/module/geometry/ui.py b/src/blenderbim/blenderbim/bim/module/geometry/ui.py
@@ -510,4 +510,5 @@ def draw_item(self, context, layout, data, item, icon, active_data, active_propn
             row.label(text=item.name, icon=icon)
             if item.layer:
                 row.label(text="", icon="STICKY_UVS_LOC")
-            row.operator("bim.remove_representation_item", icon="X", text="")
+            op = row.operator("bim.remove_representation_item", icon="X", text="")
+            op.representation_item_id = item.ifc_definition_id
