Skip to content

Commit 6126913

Browse files
committed
cmake - clean up a bit in non-advanced variables
1 parent 5a0f8d3 commit 6126913

File tree

6 files changed

+10
-0
lines changed

6 files changed

+10
-0
lines changed

cmake/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ if(CCACHE_FOUND)
152152
endif()
153153
endif()
154154
endif()
155+
mark_as_advanced(CCACHE_FOUND)
155156

156157
# Variable to accumulate swig definitions from various submodules.
157158
set(SWIG_DEFINES "")
@@ -239,6 +240,7 @@ if (WITH_ROCKSDB)
239240
set(CMAKE_FIND_PACKAGE_PREFER_CONFIG TRUE)
240241
endif()
241242
find_package(RocksDB CONFIG REQUIRED)
243+
mark_as_advanced(RocksDB_DIR)
242244
if(WIN32)
243245
set(CMAKE_FIND_PACKAGE_PREFER_CONFIG ${TEMP})
244246
endif()
@@ -253,6 +255,7 @@ if (WITH_ROCKSDB)
253255
# the libzstd.a along with the rocksdb library when needed and feature
254256
# detect based on rocksdb API?
255257
find_package(zstd CONFIG REQUIRED)
258+
mark_as_advanced(zstd_DIR)
256259
message(STATUS "zstd: found at '${zstd_DIR}'.")
257260
link_libraries(zstd::libzstd_static)
258261

cmake/FindHDF5.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ endif()
8686
if(NOT HDF5_INCLUDE_DIR OR NOT HDF5_LIBRARY_DIR)
8787
# First try to find it as a config.
8888
find_package(HDF5 CONFIG)
89+
mark_as_advanced(HDF5_DIR)
8990
if(HDF5_DIR)
9091
message(STATUS "HDF5: found config at '${HDF5_DIR}'.")
9192
set(HDF5_LIBRARIES hdf5_cpp-static)

cmake/FindOpenCASCADE.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@ if(NOT OCC_INCLUDE_DIR AND NOT OCC_LIBRARY_DIR)
3333
# OpenCASCADE may be built with VTK support. Try to find VTK first to avoid
3434
# CMake errors when OpenCASCADE's config references VTK targets.
3535
find_package(VTK QUIET)
36+
mark_as_advanced(VTK_DIR)
3637

3738
find_package(OpenCASCADE CONFIG REQUIRED)
39+
mark_as_advanced(OpenCASCADE_DIR)
3840
message(STATUS "Found OpenCASCADE config: ${OpenCASCADE_DIR}")
3941

4042
if(OpenCASCADE_VERSION VERSION_LESS "7.9.0")

cmake/FindOpenCOLLADA.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ if(NOT OPENCOLLADA_INCLUDE_DIR AND NOT OPENCOLLADA_LIBRARY_DIR)
2121
# If package is found, automatically sets
2222
# OPENCOLLADA_INCLUDE_DIRS and OPENCOLLADA_LIBRARIES (list of targets, not paths).
2323
find_package(OpenCOLLADA CONFIG)
24+
mark_as_advanced(OpenCOLLADA_DIR)
2425
if(OpenCOLLADA_DIR)
2526
message(STATUS "Found OpenCOLLADA: '${OpenCOLLADA_DIR}'.")
2627
set(OPENCOLLADA_FOUND TRUE)

cmake/Findnlohmann_json.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,14 @@ UNIFY_ENVVARS_AND_CACHE(JSON_INCLUDE_DIR)
1111

1212
if(NOT JSON_INCLUDE_DIR)
1313
find_package(nlohmann_json CONFIG)
14+
mark_as_advanced(nlohmann_json)
1415
if(nlohmann_json_DIR)
1516
return()
1617
endif()
1718
endif()
1819

1920
find_path(json_header_path "nlohmann/json.hpp" HINTS "${JSON_INCLUDE_DIR}")
21+
mark_as_advanced(json_header_path)
2022

2123
if(json_header_path)
2224
message(STATUS "JSON for Modern C++ header file found in '${json_header_path}'.")

cmake/utilities.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
macro(UNIFY_ENVVARS_AND_CACHE VAR)
2222
if(NOT DEFINED ${VAR} AND DEFINED ENV{${VAR}} AND NOT ENV{${VAR}} STREQUAL "")
2323
set(${VAR} "$ENV{${VAR}}" CACHE STRING "${VAR}" FORCE)
24+
mark_as_advanced(${VAR})
2425
endif()
2526
endmacro()
2627

0 commit comments

Comments
 (0)