#3305 Less pessimistic tolerance comparison in newells method

aothms · aothms · commit 4bbb6cd2dffe · 2023-06-14T11:47:24.000+02:00
diff --git a/src/ifcgeom_schema_agnostic/wire_utils.cpp b/src/ifcgeom_schema_agnostic/wire_utils.cpp
@@ -84,7 +84,7 @@ bool IfcGeom::util::approximate_plane_through_wire(const TopoDS_Wire& wire, gp_P
 	// the given points to the constructed plane. When doing triangulation and
 	// obtaining a 2d points for the Delaunay, infinity is passed here, so this
 	// can't for assessing degenerativeness.
-	if (v.SquareMagnitude() < 1.e-7) {
+	if (v.Magnitude() < 1.e-7) {
 		Logger::Warning("Degenerate face boundary in normal estimation");
 		return false;
 	}

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ bool IfcGeom::util::approximate_plane_through_wire(const TopoDS_Wire& wire, gp_P`
`84`	`84`	`// the given points to the constructed plane. When doing triangulation and`
`85`	`85`	`// obtaining a 2d points for the Delaunay, infinity is passed here, so this`
`86`	`86`	`// can't for assessing degenerativeness.`
`87`		`- if (v.SquareMagnitude() < 1.e-7) {`
	`87`	`+ if (v.Magnitude() < 1.e-7) {`
`88`	`88`	`Logger::Warning("Degenerate face boundary in normal estimation");`
`89`	`89`	`return false;`
`90`	`90`	`}`