cgal: Dont proceed when not valid after triangulation #6735

aothms · aothms · commit 4b92d7d076d9 · 2025-06-13T13:33:42.000+02:00
diff --git a/src/ifcgeom/kernels/cgal/CgalConversionResult.cpp b/src/ifcgeom/kernels/cgal/CgalConversionResult.cpp
@@ -240,7 +240,7 @@ void ifcopenshell::geometry::CgalShape::Triangulate(ifcopenshell::geometry::Sett
 
 		if (!shape_to_use->is_valid()) {
 			Logger::Message(Logger::LOG_ERROR, "Invalid Polyhedron_3 in object (after triangulation)");
-			// return;
+			return;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ void ifcopenshell::geometry::CgalShape::Triangulate(ifcopenshell::geometry::Sett`
`240`	`240`
`241`	`241`	`if (!shape_to_use->is_valid()) {`
`242`	`242`	`Logger::Message(Logger::LOG_ERROR, "Invalid Polyhedron_3 in object (after triangulation)");`
`243`		`- // return;`
	`243`	`+ return;`
`244`	`244`	`}`
`245`	`245`	`}`
`246`	`246`