changed comparison for type relationships

Jordan McManus · Jordan McManus · commit 3066404b4086 · 2024-04-17T14:46:07.000+02:00
diff --git a/src/ifcdiff/ifcdiff.py b/src/ifcdiff/ifcdiff.py
@@ -277,7 +277,14 @@ def diff_element_relationships(self, old, new):
             return
         for relationship in self.relationships:
             if relationship == "type":
-                if ifcopenshell.util.element.get_type(old) != ifcopenshell.util.element.get_type(new):
+                old_type = ifcopenshell.util.element.get_type(old)
+                new_type = ifcopenshell.util.element.get_type(new)
+                if old_type is not None and new_type is not None:
+                    if old_type.get_info() != new_type.get_info():
+                        self.change_register.setdefault(new.GlobalId, {}).update({"type_changed": True})
+                        return True
+                elif old_type != new_type:
+                    # one of the types is None while the other is not None
                     self.change_register.setdefault(new.GlobalId, {}).update({"type_changed": True})
                     return True
             elif relationship == "property":
