Fixed #4259

Andrej730 · Andrej730 · commit 182e428452a1 · 2024-04-16T11:28:59.000+02:00
Result of DeepDiff contain ordered sets. Also added fallback for usual sets to lists just in case, should be safe.
diff --git a/src/ifcdiff/ifcdiff.py b/src/ifcdiff/ifcdiff.py
@@ -34,6 +34,7 @@
 import ifcopenshell.util.classification
 import ifcopenshell.util.representation
 from deepdiff import DeepDiff
+from ordered_set import OrderedSet
 
 
 class IfcDiff:
@@ -234,6 +235,12 @@ def get_settings(self, ifc):
             settings.set_context_ids(body_contexts)
         return settings
 
+    def json_dump_default(self, obj):
+        # result of DeepDiff may contain ordered sets
+        if isinstance(obj, (OrderedSet, set)):
+            return list(obj)
+        return json.JSONEncoder.default(None, obj)
+
     def export(self, path):
         with open(path, "w", encoding="utf-8") as diff_file:
             json.dump(
@@ -244,6 +251,7 @@ def export(self, path):
                 },
                 diff_file,
                 indent=4,
+                default=self.json_dump_default,
             )
 
     def get_precision(self):
