Skip to content

Commit 015431f

Browse files
committed
bonsai - drop unrelated pypi aud module
Turned out `aud` module we had in our makefile had nothing to do with Blender built-in `uad` module 🫣 So no need to install anything from PyPI since this module is generally available in Blender
1 parent 95cc52a commit 015431f

3 files changed

Lines changed: 1 addition & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ jobs:
5353
python -m pip install --upgrade pip
5454
pip install xmlschema xsdata numpy lxml pytest isodate lark networkx tabulate python-dateutil shapely
5555
pip install src/bcf --no-deps
56-
pip install git+https://github.com/zdhoward/aud
5756
pip install pytest-xdist==3.8.0
5857
5958
- name: Install C++ dependencies

src/bonsai/Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,6 @@ endif
145145
cd ../ifc5d && make dist && mv dist/*.whl ../bonsai/build/wheels/
146146
cd ../ifccityjson && make dist && mv dist/*.whl ../bonsai/build/wheels/
147147
cd build && . env/$(VENV_ACTIVATE) && $(PIP) download GitPython --dest=./wheels
148-
# Provides audio playback for costing
149-
# This is a REALLY IMPORTANT feature
150-
cd build && . env/$(VENV_ACTIVATE) && $(PIP) wheel git+https://github.com/zdhoward/aud --wheel-dir=./wheels
151148
# IfcOpenShell dependency - support for new typing features
152149
cd build && . env/$(VENV_ACTIVATE) && $(PIP) download typing_extensions --dest=./wheels
153150
# Required by IfcCSV

src/bonsai/bonsai/tool/cost.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from pathlib import Path
2424
from typing import TYPE_CHECKING, Any, Literal, Optional, Union, assert_never
2525

26+
import aud
2627
import bpy
2728
import ifcopenshell.api
2829
import ifcopenshell.api.cost
@@ -149,11 +150,6 @@ def play_sound(cls) -> None:
149150
@classmethod
150151
def play_chaching_sound(cls) -> None:
151152
# TODO: make pitch higher as costs rise
152-
try:
153-
import aud
154-
except ImportError:
155-
return # ah well
156-
157153
device = aud.Device()
158154
# chaching.mp3 is by Lucish_ CC-BY-3.0 https://freesound.org/people/Lucish_/sounds/554841/
159155
filepath = tool.Blender.get_data_dir_path("chaching.mp3").__str__()

0 commit comments

Comments
 (0)