Skip to content

Commit f14c76a

Browse files
xtqqczzextqqczze
authored
Enable SA1516: Elements should be separated by blank line (PowerShell#14137)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1516.md
1 parent 9e28529 commit f14c76a

56 files changed

Lines changed: 195 additions & 1 deletion

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.globalconfig‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1401,7 +1401,7 @@ dotnet_diagnostic.SA1514.severity = none
14011401
dotnet_diagnostic.SA1515.severity = none
14021402

14031403
# SA1516: Elements should be separated by blank line
1404-
dotnet_diagnostic.SA1516.severity = none
1404+
dotnet_diagnostic.SA1516.severity = warning
14051405

14061406
# SA1517: Code should not contain blank lines at start of file
14071407
dotnet_diagnostic.SA1517.severity = none

‎src/Microsoft.PowerShell.Commands.Management/commands/management/GetComputerInfoCommand.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,6 +1335,7 @@ protected static string GetLanguageName(uint? lcid)
13351335
return null;
13361336
}
13371337
}
1338+
13381339
#pragma warning disable 649 // fields and properties in these class are assigned dynamically
13391340
[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Class is instantiated directly from a CIM instance")]
13401341
internal class WmiBaseBoard

‎src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/format-hex/Format-Hex.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ public Encoding Encoding
7777
{
7878
return _encoding;
7979
}
80+
8081
set
8182
{
8283
EncodingConversion.WarnIfObsolete(this, value);

‎src/Microsoft.PowerShell.Commands.Utility/commands/utility/Tee-Object.cs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ protected override void BeginProcessing()
111111
// the values to be written
112112
}
113113
}
114+
114115
/// <summary>
115116
/// </summary>
116117
protected override void ProcessRecord()
@@ -155,6 +156,7 @@ public void Dispose()
155156
{
156157
Dispose(false);
157158
}
159+
158160
#region private
159161
private CommandWrapper _commandWrapper;
160162
private bool _alreadyDisposed;

‎src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/ComInterfaces.cs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ void GetPath(
5757
uint fFlags);
5858

5959
void GetIDList(out IntPtr ppidl);
60+
6061
void SetIDList(IntPtr pidl);
6162

6263
void GetDescription(
@@ -82,8 +83,11 @@ void SetArguments(
8283
[MarshalAs(UnmanagedType.LPWStr)] string pszArgs);
8384

8485
void GetHotKey(out short wHotKey);
86+
8587
void SetHotKey(short wHotKey);
88+
8689
void GetShowCmd(out uint iShowCmd);
90+
8791
void SetShowCmd(uint iShowCmd);
8892

8993
void GetIconLocation(
@@ -234,6 +238,7 @@ void AddFromArray(
234238
[MarshalAs(UnmanagedType.Interface)] IObjectArray poaSource);
235239

236240
void RemoveObject(uint uiIndex);
241+
237242
void Clear();
238243
}
239244

@@ -252,6 +257,7 @@ internal interface IShellLinkDataListW
252257
Int32 RemoveDataBlock(UInt32 dwSig);
253258

254259
void GetFlags(out uint pdwFlags);
260+
255261
void SetFlags(uint dwFlags);
256262
}
257263

‎src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ internal string? ConfigurationName
327327
AssertArgumentsParsed();
328328
return _configurationName;
329329
}
330+
330331
set
331332
{
332333
if (!string.IsNullOrEmpty(value))

‎src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2986,9 +2986,13 @@ internal RunspaceCreationEventArgs(
29862986
}
29872987

29882988
internal string InitialCommand { get; set; }
2989+
29892990
internal bool SkipProfiles { get; set; }
2991+
29902992
internal bool StaMode { get; set; }
2993+
29912994
internal string ConfigurationName { get; set; }
2995+
29922996
internal Collection<CommandParameter> InitialCommandArgs { get; set; }
29932997
}
29942998
} // namespace

‎src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1345,23 +1345,29 @@ public override void WriteErrorLine(string value)
13451345

13461346
// Error colors
13471347
public ConsoleColor ErrorAccentColor { get; set; } = ConsoleColor.Cyan;
1348+
13481349
public ConsoleColor ErrorForegroundColor { get; set; } = ConsoleColor.Red;
1350+
13491351
public ConsoleColor ErrorBackgroundColor { get; set; } = Console.BackgroundColor;
13501352

13511353
// Warning colors
13521354
public ConsoleColor WarningForegroundColor { get; set; } = ConsoleColor.Yellow;
1355+
13531356
public ConsoleColor WarningBackgroundColor { get; set; } = Console.BackgroundColor;
13541357

13551358
// Debug colors
13561359
public ConsoleColor DebugForegroundColor { get; set; } = ConsoleColor.Yellow;
1360+
13571361
public ConsoleColor DebugBackgroundColor { get; set; } = Console.BackgroundColor;
13581362

13591363
// Verbose colors
13601364
public ConsoleColor VerboseForegroundColor { get; set; } = ConsoleColor.Yellow;
1365+
13611366
public ConsoleColor VerboseBackgroundColor { get; set; } = Console.BackgroundColor;
13621367

13631368
// Progress colors
13641369
public ConsoleColor ProgressForegroundColor { get; set; } = ConsoleColor.Black;
1370+
13651371
public ConsoleColor ProgressBackgroundColor { get; set; } = ConsoleColor.Yellow;
13661372

13671373
#endregion Line-oriented interaction

‎src/Microsoft.PowerShell.CoreCLR.Eventing/AssemblyInfo.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
// Licensed under the MIT License.
33

44
using System.Runtime.CompilerServices;
5+
56
[assembly: InternalsVisibleTo("System.Management.Automation,PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]

‎src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/UnsafeNativeMethods.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ internal static extern unsafe uint EventWriteString(
177177
[In] long keywords,
178178
[In] char* message
179179
);
180+
180181
// ActivityId Control APIs
181182
[DllImport(EventProviderDllName, ExactSpelling = true, EntryPoint = "EventActivityIdControl", CharSet = System.Runtime.InteropServices.CharSet.Unicode)]
182183
[SecurityCritical]

0 commit comments

Comments
 (0)