Enable IDE0040: AddAccessibilityModifiers (PowerShell#13962)

xtqqczze · web-flow · commit 23deb41f49af · 2020-11-09T09:37:25.000+05:00
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040
diff --git a/.globalconfig b/.globalconfig
@@ -845,7 +845,7 @@ dotnet_diagnostic.IDE0038.severity = silent
 dotnet_diagnostic.IDE0039.severity = silent
 
 # IDE0040: AddAccessibilityModifiers
-dotnet_diagnostic.IDE0040.severity = silent
+dotnet_diagnostic.IDE0040.severity = warning
 
 # IDE0041: UseIsNullCheck
 dotnet_diagnostic.IDE0041.severity = silent
diff --git a/src/System.Management.Automation/engine/PSConfiguration.cs b/src/System.Management.Automation/engine/PSConfiguration.cs
@@ -290,12 +290,12 @@ internal PSLevel GetLogLevel()
         /// <summary>
         /// The supported separator characters for listing channels and keywords in configuration.
         /// </summary>
-        static readonly char[] s_valueSeparators = new char[] {' ', ',', '|'};
+        private static readonly char[] s_valueSeparators = new char[] {' ', ',', '|'};
 
         /// <summary>
         /// Provides a string name to indicate the default for a configuration setting.
         /// </summary>
-        const string LogDefaultValue = "default";
+        private const string LogDefaultValue = "default";
 
         /// <summary>
         /// Gets the bitmask of the PSChannel values to log.
diff --git a/src/System.Management.Automation/utils/tracing/SysLogProvider.cs b/src/System.Management.Automation/utils/tracing/SysLogProvider.cs
@@ -80,11 +80,12 @@ namespace System.Management.Automation.Tracing
     internal class SysLogProvider
     {
         // Ensure the string pointer is not garbage collected.
-        static IntPtr _nativeSyslogIdent = IntPtr.Zero;
-        static readonly NativeMethods.SysLogPriority _facility = NativeMethods.SysLogPriority.Local0;
-        readonly byte _channelFilter;
-        readonly ulong _keywordFilter;
-        readonly byte _levelFilter;
+        private static IntPtr _nativeSyslogIdent = IntPtr.Zero;
+        private static readonly NativeMethods.SysLogPriority _facility = NativeMethods.SysLogPriority.Local0;
+
+        private readonly byte _channelFilter;
+        private readonly ulong _keywordFilter;
+        private readonly byte _levelFilter;
 
         /// <summary>
         /// Initializes a new instance of this class.
@@ -147,7 +148,7 @@ private static StringBuilder MessageBuilder
         /// to ensure correct thread initialization.
         /// </remarks>
         [ThreadStatic]
-        static Guid? t_activity;
+        private static Guid? t_activity;
 
         private static Guid Activity
         {
@@ -275,7 +276,7 @@ private static void GetEventMessage(StringBuilder sb, PSEventId eventId, params
 #region logging
 
         // maps a LogLevel to an associated SysLogPriority.
-        static readonly NativeMethods.SysLogPriority[] _levels =
+        private static readonly NativeMethods.SysLogPriority[] _levels =
         {
             NativeMethods.SysLogPriority.Info,
             NativeMethods.SysLogPriority.Critical,
@@ -374,7 +375,7 @@ internal enum LogLevel : uint
 
     internal static class NativeMethods
     {
-        const string libpslnative = "libpsl-native";
+        private const string libpslnative = "libpsl-native";
         /// <summary>
         /// Write a message to the system logger, which in turn writes the message to the system console, log files, etc.
         /// See man 3 syslog for more info.
diff --git a/test/tools/TestExe/TestExe.cs b/test/tools/TestExe/TestExe.cs
@@ -7,9 +7,9 @@
 
 namespace TestExe
 {
-    class TestExe
+    internal class TestExe
     {
-        static int Main(string[] args)
+        private static int Main(string[] args)
         {
             if (args.Length > 0)
             {
@@ -44,7 +44,7 @@ static int Main(string[] args)
         // <Summary>
         // Echos back to stdout the arguments passed in
         // </Summary>
-        static void EchoArgs(string[] args)
+        private static void EchoArgs(string[] args)
         {
             for (int i = 1; i < args.Length; i++)
             {
@@ -56,7 +56,7 @@ static void EchoArgs(string[] args)
         // First argument is the number of child processes to create which are instances of itself
         // Processes automatically exit after 100 seconds
         // </Summary>
-        static void CreateChildProcess(string[] args)
+        private static void CreateChildProcess(string[] args)
         {
             if (args.Length > 1)
             {
diff --git a/test/tools/TestService/Program.cs b/test/tools/TestService/Program.cs
@@ -5,9 +5,9 @@
 
 namespace TestService
 {
-    static class Program
+    internal static class Program
     {
-       static void Main()
+       private static void Main()
         {
             ServiceBase[] ServicesToRun;
             ServicesToRun = new ServiceBase[]

Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,9 @@`
`7`	`7`
`8`	`8`	`namespace TestExe`
`9`	`9`	`{`
`10`		`- class TestExe`
	`10`	`+ internal class TestExe`
`11`	`11`	`{`
`12`		`- static int Main(string[] args)`
	`12`	`+ private static int Main(string[] args)`
`13`	`13`	`{`
`14`	`14`	`if (args.Length > 0)`
`15`	`15`	`{`
`@@ -44,7 +44,7 @@ static int Main(string[] args)`
`44`	`44`	`// <Summary>`
`45`	`45`	`// Echos back to stdout the arguments passed in`
`46`	`46`	`// </Summary>`
`47`		`- static void EchoArgs(string[] args)`
	`47`	`+ private static void EchoArgs(string[] args)`
`48`	`48`	`{`
`49`	`49`	`for (int i = 1; i < args.Length; i++)`
`50`	`50`	`{`
`@@ -56,7 +56,7 @@ static void EchoArgs(string[] args)`
`56`	`56`	`// First argument is the number of child processes to create which are instances of itself`
`57`	`57`	`// Processes automatically exit after 100 seconds`
`58`	`58`	`// </Summary>`
`59`		`- static void CreateChildProcess(string[] args)`
	`59`	`+ private static void CreateChildProcess(string[] args)`
`60`	`60`	`{`
`61`	`61`	`if (args.Length > 1)`
`62`	`62`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,9 @@`
`5`	`5`
`6`	`6`	`namespace TestService`
`7`	`7`	`{`
`8`		`- static class Program`
	`8`	`+ internal static class Program`
`9`	`9`	`{`
`10`		`- static void Main()`
	`10`	`+ private static void Main()`
`11`	`11`	`{`
`12`	`12`	`ServiceBase[] ServicesToRun;`
`13`	`13`	`ServicesToRun = new ServiceBase[]`