Fix issue PowerShell#12013 - not allow mixed dash and slash in command line parameter prefix (PowerShell#15142)

davidBar-On · web-flow · commit 20d917c0868e · 2021-04-13T13:20:28.000-07:00
diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
@@ -608,7 +608,8 @@ internal static string GetConfigurationNameFromGroupPolicy()
                 return (switchKey: string.Empty, shouldBreak: false);
             }
 
-            if (!CharExtensions.IsDash(switchKey[0]) && switchKey[0] != '/')
+            char firstChar = switchKey[0];
+            if (!CharExtensions.IsDash(firstChar) && firstChar != '/')
             {
                 // then it's a file
                 --argIndex;
@@ -622,7 +623,7 @@ internal static string GetConfigurationNameFromGroupPolicy()
             switchKey = switchKey.Substring(1);
 
             // chop off the second dash so we're agnostic wrt specifying - or --
-            if (!string.IsNullOrEmpty(switchKey) && CharExtensions.IsDash(switchKey[0]))
+            if (!string.IsNullOrEmpty(switchKey) && CharExtensions.IsDash(firstChar) && switchKey[0] == firstChar)
             {
                 switchKey = switchKey.Substring(1);
             }
diff --git a/test/xUnit/csharp/test_CommandLineParser.cs b/test/xUnit/csharp/test_CommandLineParser.cs
@@ -143,6 +143,47 @@ public static void TestParameterIs_Wrong_Value(params string[] commandLine)
             Assert.Contains("-noprofile", cpp.ErrorMessage);
         }
 
+        [Theory]
+        [InlineData("-Version")]
+        [InlineData("--Version")]
+        [InlineData("/Version")]
+        public static void TestParameter_Dash_Or_Slash(params string[] commandLine)
+        {
+            var cpp = new CommandLineParameterParser();
+
+            cpp.Parse(commandLine);
+
+            Assert.False(cpp.AbortStartup);
+            Assert.False(cpp.NoExit);
+            Assert.True(cpp.NonInteractive);
+            Assert.False(cpp.ShowBanner);
+            Assert.False(cpp.ShowShortHelp);
+            Assert.False(cpp.NoPrompt);
+            Assert.True(cpp.ShowVersion);
+            Assert.True(cpp.SkipProfiles);
+            Assert.Null(cpp.ErrorMessage);
+        }
+
+        [Theory]
+        [InlineData("/-Version")]
+        [InlineData("-/Version")]
+        public static void TestParameter_Wrong_Dash_And_Slash(params string[] commandLine)
+        {
+            var cpp = new CommandLineParameterParser();
+
+            cpp.Parse(commandLine);
+
+            Assert.True(cpp.AbortStartup);
+            Assert.False(cpp.NoExit);
+            Assert.False(cpp.NonInteractive);
+            Assert.False(cpp.ShowBanner);
+            Assert.True(cpp.ShowShortHelp);
+            Assert.False(cpp.NoPrompt);
+            Assert.False(cpp.ShowVersion);
+            Assert.False(cpp.SkipProfiles);
+            Assert.Contains(commandLine[0], cpp.ErrorMessage);
+        }
+
         [Theory]
         [InlineData("-Version")]
         [InlineData("-V")]

Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,8 @@ internal static string GetConfigurationNameFromGroupPolicy()`
`608`	`608`	`return (switchKey: string.Empty, shouldBreak: false);`
`609`	`609`	`}`
`610`	`610`
`611`		`- if (!CharExtensions.IsDash(switchKey[0]) && switchKey[0] != '/')`
	`611`	`+ char firstChar = switchKey[0];`
	`612`	`+ if (!CharExtensions.IsDash(firstChar) && firstChar != '/')`
`612`	`613`	`{`
`613`	`614`	`// then it's a file`
`614`	`615`	`--argIndex;`
`@@ -622,7 +623,7 @@ internal static string GetConfigurationNameFromGroupPolicy()`
`622`	`623`	`switchKey = switchKey.Substring(1);`
`623`	`624`
`624`	`625`	`// chop off the second dash so we're agnostic wrt specifying - or --`
`625`		`- if (!string.IsNullOrEmpty(switchKey) && CharExtensions.IsDash(switchKey[0]))`
	`626`	`+ if (!string.IsNullOrEmpty(switchKey) && CharExtensions.IsDash(firstChar) && switchKey[0] == firstChar)`
`626`	`627`	`{`
`627`	`628`	`switchKey = switchKey.Substring(1);`
`628`	`629`	`}`