Enable IDE0082: ConvertTypeOfToNameOf (PowerShell#14042)

xtqqczze · web-flow · commit 006fe4d2dd1b · 2020-11-16T19:56:07.000+05:00
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0082
diff --git a/.globalconfig b/.globalconfig
@@ -971,7 +971,7 @@ dotnet_diagnostic.IDE0080.severity = silent
 dotnet_diagnostic.IDE0081.severity = silent
 
 # IDE0082: ConvertTypeOfToNameOf
-dotnet_diagnostic.IDE0082.severity = silent
+dotnet_diagnostic.IDE0082.severity = warning
 
 # IDE0083: UseNotPattern
 dotnet_diagnostic.IDE0083.severity = silent
diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs
@@ -2741,7 +2741,7 @@ private bool IsIncompleteParseException(Exception e)
                     return false;
                 }
 
-                return remoteException.ErrorRecord.CategoryInfo.Reason == typeof(IncompleteParseException).Name;
+                return remoteException.ErrorRecord.CategoryInfo.Reason == nameof(IncompleteParseException);
             }
 
             private void EvaluateSuggestions(ConsoleHostUserInterface ui)
diff --git a/src/System.Management.Automation/engine/Attributes.cs b/src/System.Management.Automation/engine/Attributes.cs
@@ -1092,7 +1092,7 @@ private void ValidateRange(object element, ValidateRangeKind rangeKind)
                     innerException: null,
                     Metadata.ValidateRangeElementType,
                     element.GetType().Name,
-                    typeof(int).Name);
+                    nameof(Int32));
             }
 
             object resultValue;
diff --git a/src/System.Management.Automation/engine/CmdletInfo.cs b/src/System.Management.Automation/engine/CmdletInfo.cs
@@ -548,7 +548,7 @@ internal override bool ImplementsDynamicParameters
             {
                 if (ImplementingType != null)
                 {
-                    return (ImplementingType.GetInterface(typeof(IDynamicParameters).Name, true) != null);
+                    return (ImplementingType.GetInterface(nameof(IDynamicParameters), true) != null);
                 }
                 else
                 {
diff --git a/src/System.Management.Automation/engine/CommandMetadata.cs b/src/System.Management.Automation/engine/CommandMetadata.cs
@@ -680,7 +680,7 @@ private void ConstructCmdletMetadataUsingReflection()
 
             // Determine if the cmdlet implements dynamic parameters by looking for the interface
 
-            Type dynamicParametersType = CommandType.GetInterface(typeof(IDynamicParameters).Name, true);
+            Type dynamicParametersType = CommandType.GetInterface(nameof(IDynamicParameters), true);
 
             if (dynamicParametersType != null)
             {
diff --git a/src/System.Management.Automation/engine/CompiledCommandParameter.cs b/src/System.Management.Automation/engine/CompiledCommandParameter.cs
@@ -625,7 +625,7 @@ internal ParameterCollectionTypeInformation(Type type)
                 return;
             }
 
-            bool implementsIList = (type.GetInterface(typeof(IList).Name) != null);
+            bool implementsIList = (type.GetInterface(nameof(IList)) != null);
 
             // Look for class Collection<T>.  Collection<T> implements IList, and also IList
             // is more efficient to bind than ICollection<T>.  This optimization
diff --git a/src/System.Management.Automation/engine/MshObjectTypeDescriptor.cs b/src/System.Management.Automation/engine/MshObjectTypeDescriptor.cs
@@ -222,8 +222,8 @@ private static PSObject GetComponentPSObject(object component)
                 {
                     throw PSTraceSource.NewArgumentException(nameof(component), ExtendedTypeSystem.InvalidComponent,
                                                              "component",
-                                                             typeof(PSObject).Name,
-                                                             typeof(PSObjectTypeDescriptor).Name);
+                                                             nameof(PSObject),
+                                                             nameof(PSObjectTypeDescriptor));
                 }
 
                 mshObj = descriptor.Instance;
diff --git a/src/System.Management.Automation/engine/debugger/debugger.cs b/src/System.Management.Automation/engine/debugger/debugger.cs
@@ -4138,7 +4138,7 @@ internal void TraceVariableSet(string varName, object value)
             // because 'ToStringParser' would iterate through the enumerator to get the individual elements, which will
             // make irreversible changes to the enumerator.
             bool isValueAnIEnumerator = PSObject.Base(value) is IEnumerator;
-            string valAsString = isValueAnIEnumerator ? typeof(IEnumerator).Name : PSObject.ToStringParser(_context, value);
+            string valAsString = isValueAnIEnumerator ? nameof(IEnumerator) : PSObject.ToStringParser(_context, value);
             int msgLength = 60 - varName.Length;
 
             if (valAsString.Length > msgLength)
diff --git a/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs b/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
@@ -680,12 +680,12 @@ internal static Type GetFieldType(FieldDescription field)
 
         internal static bool IsSecuritySensitiveType(string typeName)
         {
-            if (typeName.Equals(typeof(PSCredential).Name, StringComparison.OrdinalIgnoreCase))
+            if (typeName.Equals(nameof(PSCredential), StringComparison.OrdinalIgnoreCase))
             {
                 return true;
             }
 
-            if (typeName.Equals(typeof(SecureString).Name, StringComparison.OrdinalIgnoreCase))
+            if (typeName.Equals(nameof(SecureString), StringComparison.OrdinalIgnoreCase))
             {
                 return true;
             }
diff --git a/src/System.Management.Automation/engine/remoting/client/remoterunspace.cs b/src/System.Management.Automation/engine/remoting/client/remoterunspace.cs
@@ -1936,7 +1936,7 @@ public override DebuggerCommandResults ProcessCommand(PSCommand command, PSDataC
                     {
                         // Allow the IncompleteParseException to throw so that the console
                         // can handle here strings and continued parsing.
-                        if (re.ErrorRecord.CategoryInfo.Reason == typeof(IncompleteParseException).Name)
+                        if (re.ErrorRecord.CategoryInfo.Reason == nameof(IncompleteParseException))
                         {
                             throw new IncompleteParseException(
                                 (re.ErrorRecord.Exception != null) ? re.ErrorRecord.Exception.Message : null,
@@ -1945,8 +1945,8 @@ public override DebuggerCommandResults ProcessCommand(PSCommand command, PSDataC
 
                         // Allow the RemoteException and InvalidRunspacePoolStateException to propagate so that the host can
                         // clean up the debug session.
-                        if ((re.ErrorRecord.CategoryInfo.Reason == typeof(InvalidRunspacePoolStateException).Name) ||
-                            (re.ErrorRecord.CategoryInfo.Reason == typeof(RemoteException).Name))
+                        if ((re.ErrorRecord.CategoryInfo.Reason == nameof(InvalidRunspacePoolStateException)) ||
+                            (re.ErrorRecord.CategoryInfo.Reason == nameof(RemoteException)))
                         {
                             throw new PSRemotingTransportException(
                                 (re.ErrorRecord.Exception != null) ? re.ErrorRecord.Exception.Message : string.Empty);
diff --git a/test/xUnit/csharp/test_AstDefaultVisit.cs b/test/xUnit/csharp/test_AstDefaultVisit.cs
@@ -44,7 +44,7 @@ public static class AstDefaultVisitTests
         public static void TestCustomAstVisitor()
         {
             var ast = Parser.ParseInput("a | b", out _, out _);
-            var expected = typeof(NamedBlockAst).Name;
+            var expected = nameof(NamedBlockAst);
 
             var myVisitor1 = new MyICustomAstVisitor2();
             var result1 = ast.EndBlock.Accept(myVisitor1);

Original file line number	Diff line number	Diff line change
`@@ -2741,7 +2741,7 @@ private bool IsIncompleteParseException(Exception e)`
`2741`	`2741`	`return false;`
`2742`	`2742`	`}`
`2743`	`2743`
`2744`		`- return remoteException.ErrorRecord.CategoryInfo.Reason == typeof(IncompleteParseException).Name;`
	`2744`	`+ return remoteException.ErrorRecord.CategoryInfo.Reason == nameof(IncompleteParseException);`
`2745`	`2745`	`}`
`2746`	`2746`
`2747`	`2747`	`private void EvaluateSuggestions(ConsoleHostUserInterface ui)`
Original file line number	Diff line number	Diff line change
`@@ -1092,7 +1092,7 @@ private void ValidateRange(object element, ValidateRangeKind rangeKind)`
`1092`	`1092`	`innerException: null,`
`1093`	`1093`	`Metadata.ValidateRangeElementType,`
`1094`	`1094`	`element.GetType().Name,`
`1095`		`- typeof(int).Name);`
	`1095`	`+ nameof(Int32));`
`1096`	`1096`	`}`
`1097`	`1097`
`1098`	`1098`	`object resultValue;`
Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,7 @@ internal override bool ImplementsDynamicParameters`
`548`	`548`	`{`
`549`	`549`	`if (ImplementingType != null)`
`550`	`550`	`{`
`551`		`- return (ImplementingType.GetInterface(typeof(IDynamicParameters).Name, true) != null);`
	`551`	`+ return (ImplementingType.GetInterface(nameof(IDynamicParameters), true) != null);`
`552`	`552`	`}`
`553`	`553`	`else`
`554`	`554`	`{`
Original file line number	Diff line number	Diff line change
`@@ -680,7 +680,7 @@ private void ConstructCmdletMetadataUsingReflection()`
`680`	`680`
`681`	`681`	`// Determine if the cmdlet implements dynamic parameters by looking for the interface`
`682`	`682`
`683`		`- Type dynamicParametersType = CommandType.GetInterface(typeof(IDynamicParameters).Name, true);`
	`683`	`+ Type dynamicParametersType = CommandType.GetInterface(nameof(IDynamicParameters), true);`
`684`	`684`
`685`	`685`	`if (dynamicParametersType != null)`
`686`	`686`	`{`
Original file line number	Diff line number	Diff line change
`@@ -625,7 +625,7 @@ internal ParameterCollectionTypeInformation(Type type)`
`625`	`625`	`return;`
`626`	`626`	`}`
`627`	`627`
`628`		`- bool implementsIList = (type.GetInterface(typeof(IList).Name) != null);`
	`628`	`+ bool implementsIList = (type.GetInterface(nameof(IList)) != null);`
`629`	`629`
`630`	`630`	`// Look for class Collection<T>. Collection<T> implements IList, and also IList`
`631`	`631`	`// is more efficient to bind than ICollection<T>. This optimization`
Original file line number	Diff line number	Diff line change
`@@ -222,8 +222,8 @@ private static PSObject GetComponentPSObject(object component)`
`222`	`222`	`{`
`223`	`223`	`throw PSTraceSource.NewArgumentException(nameof(component), ExtendedTypeSystem.InvalidComponent,`
`224`	`224`	`"component",`
`225`		`- typeof(PSObject).Name,`
`226`		`- typeof(PSObjectTypeDescriptor).Name);`
	`225`	`+ nameof(PSObject),`
	`226`	`+ nameof(PSObjectTypeDescriptor));`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`mshObj = descriptor.Instance;`
Original file line number	Diff line number	Diff line change
`@@ -680,12 +680,12 @@ internal static Type GetFieldType(FieldDescription field)`
`680`	`680`
`681`	`681`	`internal static bool IsSecuritySensitiveType(string typeName)`
`682`	`682`	`{`
`683`		`- if (typeName.Equals(typeof(PSCredential).Name, StringComparison.OrdinalIgnoreCase))`
	`683`	`+ if (typeName.Equals(nameof(PSCredential), StringComparison.OrdinalIgnoreCase))`
`684`	`684`	`{`
`685`	`685`	`return true;`
`686`	`686`	`}`
`687`	`687`
`688`		`- if (typeName.Equals(typeof(SecureString).Name, StringComparison.OrdinalIgnoreCase))`
	`688`	`+ if (typeName.Equals(nameof(SecureString), StringComparison.OrdinalIgnoreCase))`
`689`	`689`	`{`
`690`	`690`	`return true;`
`691`	`691`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1936,7 +1936,7 @@ public override DebuggerCommandResults ProcessCommand(PSCommand command, PSDataC`
`1936`	`1936`	`{`
`1937`	`1937`	`// Allow the IncompleteParseException to throw so that the console`
`1938`	`1938`	`// can handle here strings and continued parsing.`
`1939`		`- if (re.ErrorRecord.CategoryInfo.Reason == typeof(IncompleteParseException).Name)`
	`1939`	`+ if (re.ErrorRecord.CategoryInfo.Reason == nameof(IncompleteParseException))`
`1940`	`1940`	`{`
`1941`	`1941`	`throw new IncompleteParseException(`
`1942`	`1942`	`(re.ErrorRecord.Exception != null) ? re.ErrorRecord.Exception.Message : null,`
`@@ -1945,8 +1945,8 @@ public override DebuggerCommandResults ProcessCommand(PSCommand command, PSDataC`
`1945`	`1945`
`1946`	`1946`	`// Allow the RemoteException and InvalidRunspacePoolStateException to propagate so that the host can`
`1947`	`1947`	`// clean up the debug session.`
`1948`		`- if ((re.ErrorRecord.CategoryInfo.Reason == typeof(InvalidRunspacePoolStateException).Name) \|\|`
`1949`		`- (re.ErrorRecord.CategoryInfo.Reason == typeof(RemoteException).Name))`
	`1948`	`+ if ((re.ErrorRecord.CategoryInfo.Reason == nameof(InvalidRunspacePoolStateException)) \|\|`
	`1949`	`+ (re.ErrorRecord.CategoryInfo.Reason == nameof(RemoteException)))`
`1950`	`1950`	`{`
`1951`	`1951`	`throw new PSRemotingTransportException(`
`1952`	`1952`	`(re.ErrorRecord.Exception != null) ? re.ErrorRecord.Exception.Message : string.Empty);`