refactor: replace user provider with module facade pattern

fiqrikm18 · fiqrikm18 · commit cc394c02a17f · 2026-08-01T13:32:42.000+07:00
diff --git a/.importlinter b/.importlinter
@@ -8,6 +8,7 @@ allow_indirect_imports = True
 source_modules =
     src.modules.todo
 forbidden_modules =
+    src.modules.user.providers
     src.modules.user.application
     src.modules.user.domain
     src.modules.user.infrastructure
diff --git a/src/core/dependency/facades.py b/src/core/dependency/facades.py
@@ -1,11 +1,11 @@
 from fastapi import Depends
 
 from src.core.database.postgres.session import get_unit_of_work
-from src.modules.user.providers import UserModuleProvider
+from src.modules.user.facade import UserModuleFacade
 from src.shared.unit_of_work import UnitOfWork
 
 
-def get_user_module_provider(
+def get_user_module_facade(
     uow: UnitOfWork = Depends(get_unit_of_work),
-) -> UserModuleProvider:
-    return UserModuleProvider(user_repository=uow.users)
+) -> UserModuleFacade:
+    return UserModuleFacade(user_repository=uow.users)
diff --git a/src/modules/todo/application/detail_todo/handler.py b/src/modules/todo/application/detail_todo/handler.py
@@ -5,17 +5,17 @@
 )
 from src.modules.todo.presentation.schemas.response import TodoWithOwnerResponse
 from src.modules.user import UserNotFoundError
-from src.modules.user.providers import UserModuleProvider
+from src.modules.user.facade import UserModuleFacade
 
 
 class GetTodoDetailWithOwnerHandler:
     def __init__(
         self,
         todo_repo: TodoRepository,
-        user_provider: UserModuleProvider,
+        user_facade: UserModuleFacade,
     ):
         self._todo_repo = todo_repo
-        self._user_provider = user_provider
+        self._user_facade = user_facade
 
     async def execute(self, todo_id: int, user_id: int) -> TodoWithOwnerResponse:
         todo = await self._todo_repo.get_by_id(todo_id)
@@ -26,7 +26,7 @@ async def execute(self, todo_id: int, user_id: int) -> TodoWithOwnerResponse:
                 "You do not have permission to view this todo"
             )
 
-        owner = await self._user_provider.get_user_profile(todo.user_id)
+        owner = await self._user_facade.get_user_profile(todo.user_id)
         if not owner:
             raise UserNotFoundError("Todo owner not found")
 
diff --git a/src/modules/todo/presentation/dependency.py b/src/modules/todo/presentation/dependency.py
@@ -3,7 +3,7 @@
 
 from src.core.database.postgres.session import get_db, get_unit_of_work
 from src.core.dependency.tenant import get_current_tenant_id
-from src.core.dependency.providers import get_user_module_provider
+from src.core.dependency.facades import get_user_module_facade
 from src.modules.todo.application.create_todo.handler import CreateTodoHandler
 from src.modules.todo.application.delete_todo.handler import DeleteTodoHandler
 from src.modules.todo.application.detail_todo.handler import (
@@ -17,7 +17,7 @@
 from src.modules.todo.infrastructure.repositories.todo_repository import (
     SQLAlchemyTodoRepository,
 )
-from src.modules.user.providers import UserModuleProvider
+from src.modules.user.facade import UserModuleFacade
 from src.shared.unit_of_work import UnitOfWork
 
 
@@ -51,9 +51,9 @@ def get_delete_todo_handler(
 
 def get_todo_detail_with_owner_handler(
     todo_repo: TodoRepository = Depends(get_todo_repository),
-    user_provider: UserModuleProvider = Depends(get_user_module_provider),
+    user_facade: UserModuleFacade = Depends(get_user_module_facade),
 ) -> GetTodoDetailWithOwnerHandler:
-    return GetTodoDetailWithOwnerHandler(todo_repo, user_provider=user_provider)
+    return GetTodoDetailWithOwnerHandler(todo_repo, user_facade=user_facade)
 
 
 def get_todos_query_handler(
diff --git a/src/modules/user/__init__.py b/src/modules/user/__init__.py
@@ -2,7 +2,7 @@
     UserAlreadyExistsError,
     UserNotFoundError,
 )
-from src.modules.user.providers import UserProfile
+from src.modules.user.facade import UserProfile
 
 __all__ = [
     "UserProfile",
diff --git a/src/modules/user/facade.py b/src/modules/user/facade.py
@@ -3,29 +3,30 @@
 from src.modules.user.application.detail_user.handler import DetailUserQueryHandler
 from src.modules.user.application.detail_user.query import DetailUserQuery
 from src.modules.user.domain.repositories.user_repository import UserRepository
+from src.shared.facade import ModuleFacade
 
 
 class UserProfile(BaseModel):
-    id: str
+    id: int
     email: str
     username: str | None = None
 
 
-class UserModuleProvider:
+class UserModuleFacade(ModuleFacade):
     def __init__(self, user_repository: UserRepository):
         self._user_detail_query = DetailUserQueryHandler(
             user_repository=user_repository
         )
 
-    async def get_user_profile(self, user_id: str) -> UserProfile | None:
+    async def get_user_profile(self, user_id: int) -> UserProfile | None:
         user = await self._user_detail_query.execute(
-            DetailUserQuery(user_id=str(user_id))
+            DetailUserQuery(user_id=user_id)
         )
         if user is None:
             return None
 
         return UserProfile(
-            id=str(user.id),
+            id=user.id,
             email=user.email,
             username=user.username,
         )
diff --git a/src/shared/facade.py b/src/shared/facade.py
@@ -0,0 +1,9 @@
+from abc import ABC
+
+
+class ModuleFacade(ABC):
+    """Public contract a module exposes for cross-module communication.
+
+    Other modules depend only on a module's facade — never on its
+    application, domain, or infrastructure internals.
+    """
diff --git a/tests/test_user_facade.py b/tests/test_user_facade.py
@@ -0,0 +1,34 @@
+import asyncio
+
+import pytest
+
+from src.modules.user.domain.entities.user import User
+from src.modules.user.domain.exceptions.user_exception import UserNotFoundError
+from src.modules.user.facade import UserModuleFacade
+
+
+class FakeUserRepository:
+    def __init__(self, user: User | None) -> None:
+        self._user = user
+
+    async def get_by_id_with_relations(self, user_id: int) -> User | None:
+        if self._user is None or self._user.id != user_id:
+            return None
+        return self._user
+
+
+def test_facade_returns_profile_with_int_id():
+    facade = UserModuleFacade(FakeUserRepository(
+        User(id=7, email="a@example.com", password_hash="x", username="alice")
+    ))
+    profile = asyncio.run(facade.get_user_profile(7))
+    assert profile is not None
+    assert profile.id == 7
+    assert profile.email == "a@example.com"
+    assert profile.username == "alice"
+
+
+def test_facade_raises_user_not_found_for_unknown_user():
+    facade = UserModuleFacade(FakeUserRepository(None))
+    with pytest.raises(UserNotFoundError):
+        asyncio.run(facade.get_user_profile(99))

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`UserAlreadyExistsError,`
`3`	`3`	`UserNotFoundError,`
`4`	`4`	`)`
`5`		`-from src.modules.user.providers import UserProfile`
	`5`	`+from src.modules.user.facade import UserProfile`
`6`	`6`
`7`	`7`	`__all__ = [`
`8`	`8`	`"UserProfile",`