Skip to content

Commit 2710a5d

Browse files
committed
refactor: authorization module uses integer ids
1 parent d0ed6e6 commit 2710a5d

18 files changed

Lines changed: 65 additions & 91 deletions

File tree

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
from uuid import UUID
21

32
from pydantic import BaseModel
43

54

65
class DeletePermissionCommand(BaseModel):
7-
permission_id: UUID
6+
permission_id: int
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
from uuid import UUID
21

32
from pydantic import BaseModel
43

54

65
class DeleteRoleCommand(BaseModel):
7-
role_id: UUID
6+
role_id: int
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
from uuid import UUID
21

32
from pydantic import BaseModel
43

54

65
class GetPermissionQuery(BaseModel):
7-
permission_id: UUID
6+
permission_id: int
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
from uuid import UUID
21

32
from pydantic import BaseModel
43

54

65
class GetRoleQuery(BaseModel):
7-
role_id: UUID
6+
role_id: int
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
from uuid import UUID
21

32
from pydantic import BaseModel
43

54

65
class UpdatePermissionCommand(BaseModel):
7-
permission_id: UUID
6+
permission_id: int
87
resource: str | None = None
98
action: str | None = None
109
description: str | None = None
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
from uuid import UUID
21

32
from pydantic import BaseModel
43

54

65
class UpdateRoleCommand(BaseModel):
7-
role_id: UUID
6+
role_id: int
87
name: str | None = None
98
description: str | None = None

src/modules/authorization/domain/entities/permission.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
from dataclasses import dataclass
2-
from uuid import UUID, uuid4
32

43

5-
@dataclass
4+
@dataclass(kw_only=True)
65
class Permission:
7-
id: UUID
6+
id: int | None = None
87
key: str
98
resource: str
109
action: str
@@ -21,7 +20,7 @@ def create(
2120
description: str | None,
2221
) -> "Permission":
2322
return cls(
24-
id=uuid4(),
23+
id=None,
2524
key=key,
2625
resource=resource,
2726
action=action,

src/modules/authorization/domain/entities/resource.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
from dataclasses import dataclass
2-
from uuid import UUID, uuid4
32

43

5-
@dataclass
4+
@dataclass(kw_only=True)
65
class AuthorizationResource:
7-
id: UUID
6+
id: int | None = None
87
key: str
98
name: str
109
description: str | None = None
@@ -17,7 +16,7 @@ def create(
1716
description: str | None = None,
1817
) -> "AuthorizationResource":
1918
return cls(
20-
id=uuid4(),
19+
id=None,
2120
key=key,
2221
name=name,
2322
description=description,
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
from dataclasses import dataclass
2-
from uuid import UUID, uuid4
32

43

5-
@dataclass
4+
@dataclass(kw_only=True)
65
class Role:
7-
id: UUID
6+
id: int | None = None
87
name: str
98
description: str | None = None
109
created_at: str | None = None
@@ -13,7 +12,7 @@ class Role:
1312
@classmethod
1413
def create(cls, name: str, description: str | None = None) -> "Role":
1514
return cls(
16-
id=uuid4(),
15+
id=None,
1716
name=name,
1817
description=description,
1918
)

src/modules/authorization/domain/services/authorization_service.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from abc import ABC, abstractmethod
22
from datetime import datetime
3-
from uuid import UUID
43

54
from src.modules.authorization import Permission, Role
65
from src.shared.utils.cursor import CursorDirection
@@ -28,11 +27,11 @@ async def update_role(self, role: Role) -> Role | None:
2827
pass
2928

3029
@abstractmethod
31-
async def delete_role(self, role_id: UUID) -> None:
30+
async def delete_role(self, role_id: int) -> None:
3231
pass
3332

3433
@abstractmethod
35-
async def get_role(self, role_id: UUID) -> Role | None:
34+
async def get_role(self, role_id: int) -> Role | None:
3635
pass
3736

3837
@abstractmethod
@@ -43,7 +42,7 @@ async def list_roles(self) -> list[Role]:
4342
async def list_roles_cursor(
4443
self,
4544
cursor_created_at: datetime | None = None,
46-
cursor_id: UUID | None = None,
45+
cursor_id: int | None = None,
4746
limit: int = 10,
4847
direction: CursorDirection = CursorDirection.DIRECTION_NEXT,
4948
) -> tuple[list[Role], bool]:
@@ -58,11 +57,11 @@ async def update_permission(self, permission: Permission) -> Permission | None:
5857
pass
5958

6059
@abstractmethod
61-
async def delete_permission(self, permission_id: UUID) -> None:
60+
async def delete_permission(self, permission_id: int) -> None:
6261
pass
6362

6463
@abstractmethod
65-
async def get_permission(self, permission_id: UUID) -> Permission | None:
64+
async def get_permission(self, permission_id: int) -> Permission | None:
6665
pass
6766

6867
@abstractmethod
@@ -73,7 +72,7 @@ async def list_permissions(self) -> list[Permission]:
7372
async def list_permissions_cursor(
7473
self,
7574
cursor_created_at: datetime | None = None,
76-
cursor_id: UUID | None = None,
75+
cursor_id: int | None = None,
7776
limit: int = 10,
7877
direction: CursorDirection = CursorDirection.DIRECTION_NEXT,
7978
) -> tuple[list[Permission], bool]:
@@ -82,15 +81,15 @@ async def list_permissions_cursor(
8281
@abstractmethod
8382
async def assign_permission_to_role(
8483
self,
85-
role_id: UUID,
86-
permission_id: UUID,
84+
role_id: int,
85+
permission_id: int,
8786
) -> None:
8887
pass
8988

9089
@abstractmethod
9190
async def remove_permission_from_role(
9291
self,
93-
role_id: UUID,
94-
permission_id: UUID,
92+
role_id: int,
93+
permission_id: int,
9594
) -> None:
9695
pass

0 commit comments

Comments
 (0)