Explicit test and result.

hs-lsong · hs-lsong · commit f5c368296133 · 2023-12-27T09:09:51.000-05:00
diff --git a/src/main/java/com/hubspot/jinjava/interpret/NullValue.java b/src/main/java/com/hubspot/jinjava/interpret/NullValue.java
@@ -8,7 +8,9 @@
 public final class NullValue {
   public static final NullValue INSTANCE = new NullValue();
 
-  static NullValue instance() {
+  private NullValue() {}
+
+  public static NullValue instance() {
     return INSTANCE;
   }
 
diff --git a/src/test/java/com/hubspot/jinjava/lib/tag/ForTagTest.java b/src/test/java/com/hubspot/jinjava/lib/tag/ForTagTest.java
@@ -381,12 +381,13 @@ public void itAllowsCheckingOfWithinForLoop() throws NoSuchMethodException {
   public void forLoopWithNullValues() {
     context.put("number", -1);
     context.put("the_list", Lists.newArrayList(1L, 2L, null, null, null));
-    TagNode tagNode = (TagNode) fixture("loop-last-var");
-    Document dom = Jsoup.parseBodyFragment(tag.interpret(tagNode, interpreter));
-
-    assertThat(dom.select("h3")).hasSize(4);
-    dom.outputSettings().prettyPrint(true).indentAmount(4);
-    assertThat(dom.html()).contains("seven: null");
+    String template = "{% for number in the_list %} {{ number }} {% endfor %}";
+    TagNode tagNode = (TagNode) new TreeParser(interpreter, template)
+      .buildTree()
+      .getChildren()
+      .getFirst();
+    String result = tag.interpret(tagNode, interpreter);
+    assertThat(result).isEqualTo(" 1  2  null  null  null ");
   }
 
   public static boolean inForLoop() {

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,9 @@`
`8`	`8`	`public final class NullValue {`
`9`	`9`	`public static final NullValue INSTANCE = new NullValue();`
`10`	`10`
`11`		`- static NullValue instance() {`
	`11`	`+ private NullValue() {}`
	`12`	`+`
	`13`	`+ public static NullValue instance() {`
`12`	`14`	`return INSTANCE;`
`13`	`15`	`}`
`14`	`16`