Update tests to more clearly demonstrate intent

jasmith-hs · jasmith-hs · commit 8c20c269c021 · 2023-06-29T08:54:28.000-04:00
diff --git a/src/test/java/com/hubspot/jinjava/el/ext/eager/EagerAstMethodTest.java b/src/test/java/com/hubspot/jinjava/el/ext/eager/EagerAstMethodTest.java
@@ -72,21 +72,21 @@ public void itPreservesIdentifier() {
   @Test
   public void itPreservesNonDeferredIdentifier() {
     try {
-      interpreter.resolveELExpression("deferred.append(foo_map)", -1);
+      interpreter.resolveELExpression("deferred.modify(foo_map)", -1);
       fail("Should throw DeferredParsingException");
     } catch (DeferredParsingException e) {
-      assertThat(e.getDeferredEvalResult()).isEqualTo("deferred.append(foo_map)");
+      assertThat(e.getDeferredEvalResult()).isEqualTo("deferred.modify(foo_map)");
     }
   }
 
   @Test
   public void itPreservesNonDeferredIdentifierWhenSecondParamIsDeferred() {
     try {
-      interpreter.resolveELExpression("foo_list.append(foo_map, deferred)", -1);
+      interpreter.resolveELExpression("foo_list.modify(foo_map, deferred)", -1);
       fail("Should throw DeferredParsingException");
     } catch (DeferredParsingException e) {
       assertThat(e.getDeferredEvalResult())
-        .isEqualTo("foo_list.append(foo_map, deferred)");
+        .isEqualTo("foo_list.modify(foo_map, deferred)");
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -72,21 +72,21 @@ public void itPreservesIdentifier() {`
`72`	`72`	`@Test`
`73`	`73`	`public void itPreservesNonDeferredIdentifier() {`
`74`	`74`	`try {`
`75`		`- interpreter.resolveELExpression("deferred.append(foo_map)", -1);`
	`75`	`+ interpreter.resolveELExpression("deferred.modify(foo_map)", -1);`
`76`	`76`	`fail("Should throw DeferredParsingException");`
`77`	`77`	`} catch (DeferredParsingException e) {`
`78`		`- assertThat(e.getDeferredEvalResult()).isEqualTo("deferred.append(foo_map)");`
	`78`	`+ assertThat(e.getDeferredEvalResult()).isEqualTo("deferred.modify(foo_map)");`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`@Test`
`83`	`83`	`public void itPreservesNonDeferredIdentifierWhenSecondParamIsDeferred() {`
`84`	`84`	`try {`
`85`		`- interpreter.resolveELExpression("foo_list.append(foo_map, deferred)", -1);`
	`85`	`+ interpreter.resolveELExpression("foo_list.modify(foo_map, deferred)", -1);`
`86`	`86`	`fail("Should throw DeferredParsingException");`
`87`	`87`	`} catch (DeferredParsingException e) {`
`88`	`88`	`assertThat(e.getDeferredEvalResult())`
`89`		`- .isEqualTo("foo_list.append(foo_map, deferred)");`
	`89`	`+ .isEqualTo("foo_list.modify(foo_map, deferred)");`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`