Skip to content

Commit 3805331

Browse files
committed
add some static feature strategies
1 parent 390af15 commit 3805331

File tree

5 files changed

+14
-36
lines changed

5 files changed

+14
-36
lines changed

src/main/java/com/hubspot/jinjava/features/DisabledFeatureActivationStrategy.java

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/main/java/com/hubspot/jinjava/features/FeatureConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ private FeatureConfig(Map<String, FeatureActivationStrategy> features) {
1212
}
1313

1414
public FeatureActivationStrategy getFeature(String name) {
15-
return features.getOrDefault(name, DisabledFeatureActivationStrategy.getInstance());
15+
return features.getOrDefault(name, FeatureStrategies.ALWAYS_OFF);
1616
}
1717

1818
public static FeatureConfig.Builder newBuilder() {
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package com.hubspot.jinjava.features;
2+
3+
public class FeatureStrategies {
4+
public static final FeatureActivationStrategy ALWAYS_OFF = DelegatingFeatureActivationStrategy.of(
5+
() -> false
6+
);
7+
public static final FeatureActivationStrategy ALWAYS_ON = DelegatingFeatureActivationStrategy.of(
8+
() -> true
9+
);
10+
}

src/main/java/com/hubspot/jinjava/features/StaticFeatureActivationStrategy.java

Lines changed: 0 additions & 18 deletions
This file was deleted.

src/test/java/com/hubspot/jinjava/FeaturesTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
import com.hubspot.jinjava.features.DateTimeFeatureActivationStrategy;
66
import com.hubspot.jinjava.features.DelegatingFeatureActivationStrategy;
77
import com.hubspot.jinjava.features.FeatureConfig;
8+
import com.hubspot.jinjava.features.FeatureStrategies;
89
import com.hubspot.jinjava.features.Features;
9-
import com.hubspot.jinjava.features.StaticFeatureActivationStrategy;
1010
import java.time.LocalDateTime;
1111
import org.junit.Before;
1212
import org.junit.Test;
@@ -28,8 +28,8 @@ public void setUp() throws Exception {
2828
new Features(
2929
FeatureConfig
3030
.newBuilder()
31-
.add(ALWAYS_OFF, StaticFeatureActivationStrategy.of(false))
32-
.add(ALWAYS_ON, StaticFeatureActivationStrategy.of(true))
31+
.add(ALWAYS_OFF, FeatureStrategies.ALWAYS_OFF)
32+
.add(ALWAYS_ON, FeatureStrategies.ALWAYS_ON)
3333
.add(DATE_PAST, DateTimeFeatureActivationStrategy.of(LocalDateTime.MIN))
3434
.add(DATE_FUTURE, DateTimeFeatureActivationStrategy.of(LocalDateTime.MAX))
3535
.add(DELEGATING, DelegatingFeatureActivationStrategy.of(() -> delegateActive))

0 commit comments

Comments
 (0)