add correct empty doc for tags

anthmatic · anthmatic · commit 1f3ce5fd7687 · 2023-01-10T14:12:20.000-05:00
diff --git a/src/main/java/com/hubspot/jinjava/doc/JinjavaDocFactory.java b/src/main/java/com/hubspot/jinjava/doc/JinjavaDocFactory.java
@@ -69,13 +69,14 @@ private void addCodeSnippets(JinjavaDoc doc) {
 
       if (docAnnotation == null) {
         LOG.warn(
-          "Expression Test {} doesn't have a @{} annotation",
+          "Tag {} doesn't have a @{} annotation",
           tag.getName(),
           JINJAVA_DOC_CLASS.getName()
         );
-        doc.addExpTest(
-          new JinjavaDocExpTest(
+        doc.addTag(
+          new JinjavaDocTag(
             tag.getName(),
+            StringUtils.isBlank(tag.getEndTagName()),
             "",
             "",
             false,
diff --git a/src/main/java/com/hubspot/jinjava/lib/tag/CycleTag.java b/src/main/java/com/hubspot/jinjava/lib/tag/CycleTag.java
@@ -18,6 +18,7 @@
 import com.hubspot.jinjava.doc.annotations.JinjavaDoc;
 import com.hubspot.jinjava.doc.annotations.JinjavaParam;
 import com.hubspot.jinjava.doc.annotations.JinjavaSnippet;
+import com.hubspot.jinjava.doc.annotations.JinjavaTextMateSnippet;
 import com.hubspot.jinjava.interpret.JinjavaInterpreter;
 import com.hubspot.jinjava.interpret.TemplateSyntaxException;
 import com.hubspot.jinjava.tree.TagNode;
@@ -48,6 +49,7 @@
     )
   }
 )
+@JinjavaTextMateSnippet(code = "{% cycle '${1:string_to_print}' %}")
 public class CycleTag implements Tag {
   public static final String TAG_NAME = "cycle";
   public static final String LOOP_INDEX = "loop.index0";

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`import com.hubspot.jinjava.doc.annotations.JinjavaDoc;`
`19`	`19`	`import com.hubspot.jinjava.doc.annotations.JinjavaParam;`
`20`	`20`	`import com.hubspot.jinjava.doc.annotations.JinjavaSnippet;`
	`21`	`+import com.hubspot.jinjava.doc.annotations.JinjavaTextMateSnippet;`
`21`	`22`	`import com.hubspot.jinjava.interpret.JinjavaInterpreter;`
`22`	`23`	`import com.hubspot.jinjava.interpret.TemplateSyntaxException;`
`23`	`24`	`import com.hubspot.jinjava.tree.TagNode;`
`@@ -48,6 +49,7 @@`
`48`	`49`	`)`
`49`	`50`	`}`
`50`	`51`	`)`
	`52`	`+@JinjavaTextMateSnippet(code = "{% cycle '${1:string_to_print}' %}")`
`51`	`53`	`public class CycleTag implements Tag {`
`52`	`54`	`public static final String TAG_NAME = "cycle";`
`53`	`55`	`public static final String LOOP_INDEX = "loop.index0";`