Fix form's named property behavior / minor code style and add the author

rbri · rbri · commit 654349bdeef1 · 2026-03-11T15:58:49.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,10 @@
 
     <body>
         <release version="5.0.0" date="April 01, 2026" description="jdk17, Bugfixes">
+            <action type="update" dev="Lai Quang Duong">
+                In sync with the spec, a form now maintains a past names map at the form level, not on individual elements.
+                The map is populated only when form.xyz resolves to a single element, and entries are invalidated when the element's form owner changes.
+            </action>
             <action type="update" dev="rbri">
                 Upgrade commons-logging to 1.3.6.
             </action>
@@ -20,7 +24,7 @@
             <action type="update" dev="RhinoTeam">
                 core-js: Convert XML objects from 'IdScriptableObject's to descriptors.
             </action>
-            <action type="update" dev="rbri" issue="#1092">
+            <action type="fix" dev="rbri" issue="#1092">
                 select.remove() with no arguments now removes itself from the DOM.
             </action>
             <action type="update" dev="RhinoTeam">
diff --git a/src/main/java/org/htmlunit/html/HtmlButton.java b/src/main/java/org/htmlunit/html/HtmlButton.java
@@ -42,6 +42,7 @@
  * @author Ronald Brill
  * @author Frank Danek
  * @author Sven Strickroth
+ * @author Lai Quang Duong
  */
 public class HtmlButton extends HtmlElement implements DisabledElement, SubmittableElement,
                 LabelableElement, ValidatableElement {
diff --git a/src/main/java/org/htmlunit/html/HtmlFieldSet.java b/src/main/java/org/htmlunit/html/HtmlFieldSet.java
@@ -28,6 +28,7 @@
  * @author Ahmed Ashour
  * @author Frank Danek
  * @author Ronald Brill
+ * @author Lai Quang Duong
  */
 public class HtmlFieldSet extends HtmlElement implements DisabledElement, ValidatableElement {
 
diff --git a/src/main/java/org/htmlunit/html/HtmlInput.java b/src/main/java/org/htmlunit/html/HtmlInput.java
@@ -56,6 +56,7 @@
  * @author Frank Danek
  * @author Anton Demydenko
  * @author Ronny Shapiro
+ * @author Lai Quang Duong
  */
 public abstract class HtmlInput extends HtmlElement implements DisabledElement, SubmittableElement,
     ValidatableElement  {
diff --git a/src/main/java/org/htmlunit/html/HtmlOutput.java b/src/main/java/org/htmlunit/html/HtmlOutput.java
@@ -24,6 +24,7 @@
  *
  * @author Ronald Brill
  * @author Frank Danek
+ * @author Lai Quang Duong
  */
 public class HtmlOutput extends HtmlElement implements LabelableElement, ValidatableElement {
 
diff --git a/src/main/java/org/htmlunit/html/HtmlSelect.java b/src/main/java/org/htmlunit/html/HtmlSelect.java
@@ -44,6 +44,7 @@
  * @author Ahmed Ashour
  * @author Ronald Brill
  * @author Frank Danek
+ * @author Lai Quang Duong
  */
 public class HtmlSelect extends HtmlElement implements DisabledElement, SubmittableElement,
                 LabelableElement, ValidatableElement {
diff --git a/src/main/java/org/htmlunit/html/HtmlTextArea.java b/src/main/java/org/htmlunit/html/HtmlTextArea.java
@@ -41,6 +41,7 @@
  * @author Amit Khanna
  * @author Ronald Brill
  * @author Frank Danek
+ * @author Lai Quang Duong
  */
 public class HtmlTextArea extends HtmlElement implements DisabledElement, SubmittableElement,
                 LabelableElement, SelectableTextInput, ValidatableElement {
diff --git a/src/main/java/org/htmlunit/javascript/host/html/HTMLFormElement.java b/src/main/java/org/htmlunit/javascript/host/html/HTMLFormElement.java
@@ -105,23 +105,21 @@ public void setName(final String name) {
     public HTMLFormControlsCollection getElements() {
         final HtmlForm htmlForm = getHtmlForm();
 
-        final HTMLFormControlsCollection elements = new HTMLFormControlsCollection(htmlForm,
-                false) {
+        final HTMLFormControlsCollection elements = new HTMLFormControlsCollection(htmlForm, false) {
             @Override
             protected Object getWithPreemption(final String name) {
-                final List<HtmlElement> elements = findElements(name);
-                if (elements.isEmpty()) {
+                final List<HtmlElement> elementsForName = findElements(name);
+                if (elementsForName.isEmpty()) {
                     return NOT_FOUND;
                 }
-                if (elements.size() == 1) {
-                    return getScriptableFor(elements.get(0));
+                if (elementsForName.size() == 1) {
+                    return getScriptableFor(elementsForName.get(0));
                 }
 
-                final List<DomNode> nodes = new ArrayList<>(elements);
+                final List<DomNode> nodes = new ArrayList<>(elementsForName);
                 final RadioNodeList nodeList = new RadioNodeList(getHtmlForm(), nodes);
                 nodeList.setElementsSupplier(
-                        (Supplier<List<DomNode>> & Serializable)
-                        () -> new ArrayList<>(findElements(name)));
+                        (Supplier<List<DomNode>> & Serializable) () -> new ArrayList<>(findElements(name)));
                 return nodeList;
             }
         };
diff --git a/src/test/java/org/htmlunit/javascript/host/html/HTMLFormElementTest.java b/src/test/java/org/htmlunit/javascript/host/html/HTMLFormElementTest.java
@@ -47,6 +47,7 @@
  * @author Ahmed Ashour
  * @author Ronald Brill
  * @author Frank Danek
+ * @author Lai Quang Duong
  */
 public class HTMLFormElementTest extends WebDriverTestCase {
 

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`*`
`25`	`25`	`* @author Ronald Brill`
`26`	`26`	`* @author Frank Danek`
	`27`	`+ * @author Lai Quang Duong`
`27`	`28`	`*/`
`28`	`29`	`public class HtmlOutput extends HtmlElement implements LabelableElement, ValidatableElement {`
`29`	`30`