Geolocation.ctor() throws a TypeError

rbri · rbri · commit 1de2d0fb544f · 2025-02-02T19:10:07.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.10.0" date="February xx, 2025" description="Bugfixes">
+            <action type="fix" dev="rbri">
+                Geolocation.ctor() throws a TypeError.
+            </action>
             <action type="fix" dev="rbri">
                 TreeWalker.ctor() throws a TypeError.
             </action>
diff --git a/src/main/java/org/htmlunit/javascript/host/geo/Geolocation.java b/src/main/java/org/htmlunit/javascript/host/geo/Geolocation.java
@@ -47,7 +47,7 @@ public class Geolocation extends HtmlUnitScriptable {
      */
     @JsxConstructor
     public void jsConstructor() {
-        throw JavaScriptEngine.reportRuntimeError("Illegal constructor.");
+        throw JavaScriptEngine.typeError("Illegal constructor.");
     }
 
     /**
diff --git a/src/test/java/org/htmlunit/javascript/host/event/KeyboardEventTest.java b/src/test/java/org/htmlunit/javascript/host/event/KeyboardEventTest.java
@@ -446,10 +446,10 @@ public void initKeyEvent() throws Exception {
             FF_ESR = {"NotSupportedError",
                       "keydown, true, true, Fn, 0, true, true, true, true, 0, 0",
                       "keyup, false, false, , 7, false, false, false, false, 0, 0"})
-    @HtmlUnitNYI(CHROME = {"exception",
+    @HtmlUnitNYI(CHROME = {"NotSupportedError",
                            "keydown, true, true, Fn, 0, true, true, true, true, 0, 0",
                            "keyup, false, false, , 7, false, false, false, false, 0, 0"},
-                 EDGE = {"exception",
+                 EDGE = {"NotSupportedError",
                          "keydown, true, true, Fn, 0, true, true, true, true, 0, 0",
                          "keyup, false, false, , 7, false, false, false, false, 0, 0"})
     public void initKeyboardEvent() throws Exception {
diff --git a/src/test/java/org/htmlunit/javascript/host/intl/DateTimeFormat2Test.java b/src/test/java/org/htmlunit/javascript/host/intl/DateTimeFormat2Test.java
@@ -1335,7 +1335,7 @@ public void format_no_no() throws Exception {
      * @throws Exception if the test fails
      */
     @Test
-    @Alerts("exception")
+    @Alerts("RangeError")
     public void format_no_no_ny() throws Exception {
         test("new Intl.DateTimeFormat('no-NO-NY').format(date)");
     }
diff --git a/src/test/java/org/htmlunit/javascript/host/intl/NumberFormat2Test.java b/src/test/java/org/htmlunit/javascript/host/intl/NumberFormat2Test.java
@@ -1201,7 +1201,7 @@ public void format_no_no() throws Exception {
      * @throws Exception if the test fails
      */
     @Test
-    @Alerts("exception")
+    @Alerts("RangeError")
     public void format_no_no_ny() throws Exception {
         test("new Intl.NumberFormat('no-NO-NY').format(number)");
     }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public class Geolocation extends HtmlUnitScriptable {`
`47`	`47`	`*/`
`48`	`48`	`@JsxConstructor`
`49`	`49`	`public void jsConstructor() {`
`50`		`- throw JavaScriptEngine.reportRuntimeError("Illegal constructor.");`
	`50`	`+ throw JavaScriptEngine.typeError("Illegal constructor.");`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -1335,7 +1335,7 @@ public void format_no_no() throws Exception {`
`1335`	`1335`	`* @throws Exception if the test fails`
`1336`	`1336`	`*/`
`1337`	`1337`	`@Test`
`1338`		`- @Alerts("exception")`
	`1338`	`+ @Alerts("RangeError")`
`1339`	`1339`	`public void format_no_no_ny() throws Exception {`
`1340`	`1340`	`test("new Intl.DateTimeFormat('no-NO-NY').format(date)");`
`1341`	`1341`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1201,7 +1201,7 @@ public void format_no_no() throws Exception {`
`1201`	`1201`	`* @throws Exception if the test fails`
`1202`	`1202`	`*/`
`1203`	`1203`	`@Test`
`1204`		`- @Alerts("exception")`
	`1204`	`+ @Alerts("RangeError")`
`1205`	`1205`	`public void format_no_no_ny() throws Exception {`
`1206`	`1206`	`test("new Intl.NumberFormat('no-NO-NY').format(number)");`
`1207`	`1207`	`}`