Refactor examples

tshemsedinov · tshemsedinov · commit fbcc11734274 · 2019-05-19T12:16:17.000+03:00
diff --git a/JavaScript/1-proxy.js b/JavaScript/1-proxy.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const start = (data) => {
+const start = data => {
   console.log('\nstart transaction');
   let delta = {};
   const commit = () => {
diff --git a/JavaScript/2-transaction.js b/JavaScript/2-transaction.js
@@ -2,7 +2,7 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   let delta = {};
 
diff --git a/JavaScript/3-problems.js b/JavaScript/3-problems.js
@@ -2,7 +2,7 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   let delta = {};
 
diff --git a/JavaScript/4-descriptor.js b/JavaScript/4-descriptor.js
@@ -2,7 +2,7 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   let delta = {};
 
diff --git a/JavaScript/5-own-keys.js b/JavaScript/5-own-keys.js
@@ -2,7 +2,7 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   let delta = {};
 
diff --git a/JavaScript/6-delta.js b/JavaScript/6-delta.js
@@ -2,7 +2,7 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   let delta = {};
 
@@ -68,10 +68,14 @@ transaction.age = (
 console.dir({ transaction });
 console.dir({ delta: transaction.delta });
 
+const transaction2 = transaction.clone();
+
 transaction.commit();
 console.dir({ data });
 console.dir({ transaction });
+console.dir({ transaction2 });
 console.dir({ delta: transaction.delta });
+console.dir({ delta2: transaction2.delta });
 
 transaction.born = 1976;
 console.dir({ transaction });
diff --git a/JavaScript/7-delete.js b/JavaScript/7-delete.js
@@ -2,7 +2,7 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   let delta = {};
   const deleteDelta = new Set();
diff --git a/JavaScript/7-events.js b/JavaScript/7-events.js
@@ -2,14 +2,14 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   const events = {
     commit: [], rollback: [], timeout: [], change: []
   };
   let delta = {};
 
-  const emit = (name) => {
+  const emit = name => {
     const event = events[name];
     for (const listener of event) listener(data);
   };
diff --git a/JavaScript/8-dataset.js b/JavaScript/8-dataset.js
@@ -2,14 +2,14 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('\nstart transaction');
   const events = {
     commit: [], rollback: [], timeout: [], change: []
   };
   let delta = {};
 
-  const emit = (name) => {
+  const emit = name => {
     const event = events[name];
     for (const listener of event) listener(data);
   };
@@ -61,42 +61,45 @@ Transaction.start = (data) => {
   });
 };
 
-function DatasetTransaction(dataset) {
-  this.dataset = dataset;
-  this.log = []; // array of LogRecord { time, operation, delta }
-  // [
-  //    { id, time: '2018-01-01T12:01:00', operation: 'start' }
-  //    { id, time: '2018-01-01T12:02:15', operation: 'set', delta }
-  //    { id, time: '2018-01-01T12:02:32', operation: 'commit', delta }
-  //    { id, time: '2018-01-01T12:02:37', operation: 'set', delta }
-  //    { id, time: '2018-01-01T12:03:11', operation: 'rollback', delta }
-  //    { id, time: '2018-01-01T12:03:18', operation: 'set', delta }
-  //    { id, time: '2018-01-01T12:04:42', operation: 'timeout' }
-  //    { id, time: '2018-01-01T12:04:52', operation: 'rollback', delta }
-  // ]
+// Dataset `this.log` example: [
+//    { id, time: '2018-01-01T12:01:00', operation: 'start' }
+//    { id, time: '2018-01-01T12:02:15', operation: 'set', delta }
+//    { id, time: '2018-01-01T12:02:32', operation: 'commit', delta }
+//    { id, time: '2018-01-01T12:02:37', operation: 'set', delta }
+//    { id, time: '2018-01-01T12:03:11', operation: 'rollback', delta }
+//    { id, time: '2018-01-01T12:03:18', operation: 'set', delta }
+//    { id, time: '2018-01-01T12:04:42', operation: 'timeout' }
+//    { id, time: '2018-01-01T12:04:52', operation: 'rollback', delta }
+// ]
+class DatasetTransaction {
+  constructor(dataset) {
+    this.dataset = dataset;
+    this.log = []; // array of LogRecord { time, operation, delta }
+  }
+
+  static start(dataset) {
+    // place implementation here
+    return new DatasetTransaction(dataset);
+  }
+
+  commit() {
+    // place implementation here
+  }
+
+  rollback(id) {
+    // place implementation here
+  }
+
+  //  msec <number> timeout, 0 to disable
+  //  commit <boolean> true to commit, false to rollback
+  //  listener <Function> (optional)
+  //    callback <Function>
+  //      result <boolean>
+  timeout(msec, commit, listener) {
+    // place implementation here
+  }
 }
 
-DatasetTransaction.start = function(dataset) {
-  // place implementation here
-  return new DatasetTransaction(dataset);
-};
-
-DatasetTransaction.prototype.commit = function() {
-  // place implementation here
-};
-
-DatasetTransaction.prototype.rollback = function(id /* optional log id */) {
-  // place implementation here
-};
-
-DatasetTransaction.prototype.timeout = function(
-  msec, // timeout, 0 - disable
-  commit, // true - commit, false - rollback
-  listener // (optional) function(boolean) : boolean
-) {
-  // place implementation here
-};
-
 // Usage
 
 const data = [
diff --git a/JavaScript/9-separate.js b/JavaScript/9-separate.js
@@ -2,21 +2,24 @@
 
 // Interface definition
 
-function Transaction() {}
-
-Transaction.start = (data) => {
-  // place implementation here
-  return [obj, transaction];
-};
-
-// Transaction.delta
-Transaction.prototype.commit = () => {};
-Transaction.prototype.rollback = () => {};
-Transaction.prototype.revoke = () => {};
-Transaction.prototype.timeout = (msec) => {};
-Transaction.prototype.before = (event, listener) => {};
-Transaction.prototype.after = (event, listener) => {};
-// Events: commit, rollback, revoke, set, get, timeout
+class Transaction {
+  constructor() {
+    // this.delta
+  }
+
+  static start(data) {
+    // place implementation here
+    return [obj, transaction];
+  }
+
+  commit() {}
+  rollback() {}
+  revoke() {}
+  timeout(msec) {}
+  before(event, listener) {}
+  after(event, listener) {}
+  // Events: commit, rollback, revoke, set, get, timeout
+}
 
 // Usage
 
diff --git a/JavaScript/b-revocable.js b/JavaScript/b-revocable.js
@@ -3,7 +3,7 @@
 const data = { name: 'Marcus' };
 
 const { proxy, revoke } = Proxy.revocable(data, {
-  get: function(target, key) {
+  get(target, key) {
     return '[[' + target[key] + ']]';
   }
 });
diff --git a/JavaScript/c-good.js b/JavaScript/c-good.js
@@ -2,7 +2,7 @@
 
 function Transaction() {}
 
-Transaction.start = (data) => {
+Transaction.start = data => {
   console.log('start transaction');
   const events = { commit: [], rollback: [], timeout: [], change: [] };
   let delta = {};
