Fix linter warnings

tshemsedinov · tshemsedinov · commit 29d296a0cce8 · 2024-12-11T12:20:33.000+02:00
diff --git a/JavaScript/1-proxy.js b/JavaScript/1-proxy.js
@@ -11,7 +11,7 @@ const start = (data) => {
   return new Proxy(data, {
     get(target, key) {
       if (key === 'commit') return commit;
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     set(target, key, val) {
diff --git a/JavaScript/2-transaction.js b/JavaScript/2-transaction.js
@@ -21,8 +21,8 @@ Transaction.start = (data) => {
   return new Proxy(data, {
     get(target, key) {
       console.log('get', key);
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     set(target, key, val) {
diff --git a/JavaScript/3-problems.js b/JavaScript/3-problems.js
@@ -20,8 +20,8 @@ Transaction.start = (data) => {
 
   return new Proxy(data, {
     get(target, key) {
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     set(target, key, val) {
diff --git a/JavaScript/4-descriptor.js b/JavaScript/4-descriptor.js
@@ -21,16 +21,16 @@ Transaction.start = (data) => {
   return new Proxy(data, {
     get(target, key) {
       console.log('get', key);
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
 
     // Added handler
     getOwnPropertyDescriptor: (target, key) => {
       console.log('getOwnPropertyDescriptor', key);
       const descriptor = Object.getOwnPropertyDescriptor(
-        delta.hasOwnProperty(key) ? delta : target,
+        Object.hasOwn(delta, key) ? delta : target,
         key,
       );
       console.dir(descriptor);
diff --git a/JavaScript/5-own-keys.js b/JavaScript/5-own-keys.js
@@ -20,13 +20,13 @@ Transaction.start = (data) => {
 
   return new Proxy(data, {
     get(target, key) {
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     getOwnPropertyDescriptor: (target, key) =>
       Object.getOwnPropertyDescriptor(
-        delta.hasOwnProperty(key) ? delta : target,
+        Object.hasOwn(delta, key) ? delta : target,
         key,
       ),
 
diff --git a/JavaScript/6-delta.js b/JavaScript/6-delta.js
@@ -27,13 +27,13 @@ Transaction.start = (data) => {
   return new Proxy(data, {
     get(target, key) {
       if (key === 'delta') return delta;
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     getOwnPropertyDescriptor: (target, key) =>
       Object.getOwnPropertyDescriptor(
-        delta.hasOwnProperty(key) ? delta : target,
+        Object.hasOwn(delta, key) ? delta : target,
         key,
       ),
     ownKeys() {
diff --git a/JavaScript/7-delete.js b/JavaScript/7-delete.js
@@ -32,13 +32,13 @@ Transaction.start = (data) => {
   return new Proxy(data, {
     get(target, key) {
       if (key === 'delta') return delta;
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     getOwnPropertyDescriptor: (target, key) =>
       Object.getOwnPropertyDescriptor(
-        delta.hasOwnProperty(key) ? delta : target,
+        Object.hasOwn(delta, key) ? delta : target,
         key,
       ),
     ownKeys() {
@@ -54,7 +54,7 @@ Transaction.start = (data) => {
       return true;
     },
     deleteProperty(target, prop) {
-      if (deleteDelta.has(prop)) return false;
+      if (Object.hasOwn(deleteDelta, prop)) return false;
       deleteDelta.add(prop);
       return true;
     },
diff --git a/JavaScript/7-events.js b/JavaScript/7-events.js
@@ -41,13 +41,13 @@ Transaction.start = (data) => {
   return new Proxy(data, {
     get(target, key) {
       if (key === 'delta') return delta;
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     getOwnPropertyDescriptor: (target, key) =>
       Object.getOwnPropertyDescriptor(
-        delta.hasOwnProperty(key) ? delta : target,
+        Object.hasOwn(delta, key) ? delta : target,
         key,
       ),
     ownKeys() {
diff --git a/JavaScript/8-dataset.js b/JavaScript/8-dataset.js
@@ -41,13 +41,13 @@ Transaction.start = (data) => {
   return new Proxy(data, {
     get(target, key) {
       if (key === 'delta') return delta;
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     getOwnPropertyDescriptor: (target, key) =>
       Object.getOwnPropertyDescriptor(
-        delta.hasOwnProperty(key) ? delta : target,
+        Object.hasOwn(delta, key) ? delta : target,
         key,
       ),
     ownKeys() {
diff --git a/JavaScript/9-separate.js b/JavaScript/9-separate.js
@@ -9,6 +9,7 @@ class Transaction {
 
   static start(data) {
     // place implementation here
+    const obj = {};
     return [obj, this];
   }
 
@@ -21,6 +22,8 @@ class Transaction {
   // Events: commit, rollback, revoke, set, get, timeout
 }
 
+module.export = { Transaction };
+
 // Usage
 
 const data = { name: 'Marcus Aurelius', born: 121 };
diff --git a/JavaScript/a-calculated.js b/JavaScript/a-calculated.js
@@ -1,5 +1,7 @@
 'use strict';
 
+const { Transaction } = require('./9-separate.js');
+
 // Usage
 
 const data = { name: 'Marcus Aurelius', born: 121, city: 'Rome' };
diff --git a/JavaScript/c-good.js b/JavaScript/c-good.js
@@ -39,16 +39,16 @@ Transaction.start = (data) => {
   const proxy = new Proxy(data, {
     get(target, key) {
       if (key === Symbol.iterator) return getKeys()[key]();
-      if (methods.hasOwnProperty(key)) return methods[key];
-      if (delta.hasOwnProperty(key)) return delta[key];
+      if (Object.hasOwn(methods, key)) return methods[key];
+      if (Object.hasOwn(delta, key)) return delta[key];
       return target[key];
     },
     ownKeys() {
       return getKeys();
     },
     getOwnPropertyDescriptor: (target, key) =>
       Object.getOwnPropertyDescriptor(
-        delta.hasOwnProperty(key) ? delta : target,
+        Object.hasOwn(delta, key) ? delta : target,
         key,
       ),
     set(target, key, val) {
diff --git a/eslint.config.js b/eslint.config.js
@@ -2,4 +2,7 @@
 
 const init = require('eslint-config-metarhia');
 
+init[0].rules['class-methods-use-this'] = 'off';
+init[0].rules['no-unused-vars'] = 'off';
+
 module.exports = init;

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ class Transaction {`
`9`	`9`
`10`	`10`	`static start(data) {`
`11`	`11`	`// place implementation here`
	`12`	`+ const obj = {};`
`12`	`13`	`return [obj, this];`
`13`	`14`	`}`
`14`	`15`
`@@ -21,6 +22,8 @@ class Transaction {`
`21`	`22`	`// Events: commit, rollback, revoke, set, get, timeout`
`22`	`23`	`}`
`23`	`24`
	`25`	`+module.export = { Transaction };`
	`26`	`+`
`24`	`27`	`// Usage`
`25`	`28`
`26`	`29`	`const data = { name: 'Marcus Aurelius', born: 121 };`