Skip to content

Commit 353ed2f

Browse files
committed
Multiple minor optimizations in examples
1 parent 0bb679a commit 353ed2f

File tree

4 files changed

+29
-14
lines changed

4 files changed

+29
-14
lines changed

JavaScript/1-readable.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,18 @@
22

33
const fs = require('fs');
44

5-
const rs = fs.createReadStream('1-readable.js');
5+
const rs = fs.createReadStream('1-readable.js', 'utf8');
66

77
rs.on('readable', () => {
8+
console.log('readable');
89
const buffer = rs.read();
910
if (buffer) {
1011
console.log(buffer);
1112
console.log(buffer.toString());
1213
}
1314
});
15+
16+
rs.on('data', (chunk) => {
17+
console.log('data');
18+
console.log(chunk);
19+
});

JavaScript/2-writable.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,12 @@
22

33
const fs = require('fs');
44

5-
const rs = fs.createReadStream('1-readable.js');
6-
const ws = fs.createWriteStream('copy.js');
5+
const rs = fs.createReadStream('1-readable.js', 'utf8');
6+
const ws = fs.createWriteStream('copy.js', 'utf8');
77

8-
rs.on('readable', () => {
9-
const buffer = rs.read();
10-
if (buffer) {
11-
console.log('Copy ' + buffer.length + ' bytes');
12-
ws.write(buffer);
13-
}
8+
rs.on('data', (buffer) => {
9+
console.log('Copy ' + buffer.length + ' chars');
10+
ws.write(buffer);
1411
});
1512

1613
rs.on('end', () => {

JavaScript/3-pipe.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
const fs = require('fs');
44

5-
const rs = fs.createReadStream('1-readable.js');
6-
const ws = fs.createWriteStream('copy.js');
5+
const rs = fs.createReadStream('1-readable.js', 'utf8');
6+
const ws = fs.createWriteStream('copy.js', 'utf8');
77

88
rs.pipe(ws);
99

JavaScript/6-http-safeStart.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const fs = require('fs');
44
const zlib = require('zlib');
55
const http = require('http');
66

7-
function prepareCash(callback) {
7+
function prepareCache(callback) {
88
let buffer = null;
99

1010
const rs = fs.createReadStream('index.html');
@@ -16,15 +16,27 @@ function prepareCash(callback) {
1616
buffers.push(buffer);
1717
});
1818

19-
gs.on('end', () => {
19+
gs.once('end', () => {
2020
buffer = Buffer.concat(buffers);
2121
callback(null, buffer);
2222
});
2323

24+
rs.on('error', (error) => {
25+
callback(error);
26+
});
27+
28+
gs.on('error', (error) => {
29+
callback(error);
30+
});
31+
2432
rs.pipe(gs);
2533
}
2634

2735
function startServer(err, buffer) {
36+
if (err) {
37+
throw err;
38+
}
39+
2840
const server = http.createServer((request, response) => {
2941
console.log(request.url);
3042
response.writeHead(200, { 'Content-Encoding': 'gzip' });
@@ -34,4 +46,4 @@ function startServer(err, buffer) {
3446
server.listen(8000);
3547
}
3648

37-
prepareCash(startServer);
49+
prepareCache(startServer);

0 commit comments

Comments
 (0)