Optimize loop variables, minimize scope and use const

tshemsedinov · tshemsedinov · commit 99ca5bf4a13e · 2018-10-02T03:14:38.000+03:00
diff --git a/JavaScript/1-graph.js b/JavaScript/1-graph.js
@@ -10,9 +10,8 @@ class Vertex {
     const distinct = new Set(args);
     const links = this.links;
     const keyField = this.graph.keyField;
-    let item, key;
-    for (item of distinct) {
-      key = item.data[keyField];
+    for (const item of distinct) {
+      const key = item.data[keyField];
       links.set(key, null);
     }
     return this;
@@ -26,10 +25,9 @@ class Cursor {
   linked(...names) {
     const vertices = this.vertices;
     const result = new Set();
-    let vertex, condition, name;
-    for (vertex of vertices) {
-      condition = true;
-      for (name of names) {
+    for (const vertex of vertices) {
+      let condition = true;
+      for (const name of names) {
         condition = condition && vertex.links.has(name);
       }
       if (condition) result.add(vertex);
@@ -53,12 +51,11 @@ class Graph {
   }
   select(query) {
     const vertices = new Set();
-    let vertex, condition, data, field;
-    for (vertex of this.vertices.values()) {
-      condition = true;
-      data = vertex.data;
+    for (const vertex of this.vertices.values()) {
+      let condition = true;
+      const data = vertex.data;
       if (data) {
-        for (field in query) {
+        for (const field in query) {
           condition = condition && data[field] === query[field];
         }
         if (condition) vertices.add(vertex);
diff --git a/JavaScript/2-insert-link-to.js b/JavaScript/2-insert-link-to.js
@@ -10,9 +10,8 @@ class Vertex {
     const distinct = new Set(args);
     const links = this.links;
     const keyField = this.graph.keyField;
-    let item, key;
-    for (item of distinct) {
-      key = item.data[keyField];
+    for (const item of distinct) {
+      const key = item.data[keyField];
       links.set(key, null);
     }
     return this;
@@ -26,10 +25,9 @@ class Cursor {
   linked(...names) {
     const vertices = this.vertices;
     const result = new Set();
-    let vertex, condition, name;
-    for (vertex of vertices) {
-      condition = true;
-      for (name of names) {
+    for (const vertex of vertices) {
+      let condition = true;
+      for (const name of names) {
         condition = condition && vertex.links.has(name);
       }
       if (condition) result.add(vertex);
@@ -53,12 +51,11 @@ class Graph {
   }
   select(query) {
     const vertices = new Set();
-    let vertex, condition, data, field;
-    for (vertex of this.vertices.values()) {
-      condition = true;
-      data = vertex.data;
+    for (const vertex of this.vertices.values()) {
+      let condition = true;
+      const data = vertex.data;
       if (data) {
-        for (field in query) {
+        for (const field in query) {
           condition = condition && data[field] === query[field];
         }
         if (condition) vertices.add(vertex);
diff --git a/JavaScript/3-index.js b/JavaScript/3-index.js
@@ -10,9 +10,8 @@ class Vertex {
     const distinct = new Set(args);
     const links = this.links;
     const keyField = this.graph.keyField;
-    let item, key;
-    for (item of distinct) {
-      key = item.data[keyField];
+    for (const item of distinct) {
+      const key = item.data[keyField];
       links.set(key, null);
     }
     return this;
@@ -26,10 +25,9 @@ class Cursor {
   linked(...names) {
     const vertices = this.vertices;
     const result = new Set();
-    let vertex, condition, name;
-    for (vertex of vertices) {
-      condition = true;
-      for (name of names) {
+    for (const vertex of vertices) {
+      let condition = true;
+      for (const name of names) {
         condition = condition && vertex.links.has(name);
       }
       if (condition) result.add(vertex);
@@ -54,12 +52,11 @@ class Graph {
   }
   select(query) {
     const vertices = new Set();
-    let vertex, condition, data, field;
-    for (vertex of this.vertices.values()) {
-      condition = true;
-      data = vertex.data;
+    for (const vertex of this.vertices.values()) {
+      let condition = true;
+      const data = vertex.data;
       if (data) {
-        for (field in query) {
+        for (const field in query) {
           condition = condition && data[field] === query[field];
         }
         if (condition) vertices.add(vertex);
@@ -92,10 +89,9 @@ class Graph {
       idx = new Map();
       this.indices.set(key, idx);
     }
-    let vertex, value, records;
-    for (vertex of this.vertices.values()) {
-      value = vertex.data[key];
-      records = idx.get(value);
+    for (const vertex of this.vertices.values()) {
+      const value = vertex.data[key];
+      let records = idx.get(value);
       if (!records) {
         records = new Set();
         idx.set(value, records);
