|
| 1 | +/* |
| 2 | + * Cppcheck - A tool for static C/C++ code analysis |
| 3 | + * Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team. |
| 4 | + * |
| 5 | + * This program is free software: you can redistribute it and/or modify |
| 6 | + * it under the terms of the GNU General Public License as published by |
| 7 | + * the Free Software Foundation, either version 3 of the License, or |
| 8 | + * (at your option) any later version. |
| 9 | + * |
| 10 | + * This program is distributed in the hope that it will be useful, |
| 11 | + * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 12 | + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 13 | + * GNU General Public License for more details. |
| 14 | + * |
| 15 | + * You should have received a copy of the GNU General Public License |
| 16 | + * along with this program. If not, see <http://www.gnu.org/licenses/>. |
| 17 | + */ |
| 18 | + |
| 19 | +//--------------------------------------------------------------------------- |
| 20 | +// You should use ++ and -- as prefix whenever possible as these are more |
| 21 | +// efficient than postfix operators |
| 22 | +//--------------------------------------------------------------------------- |
| 23 | + |
| 24 | +#include "checkpostfixoperator.h" |
| 25 | +#include <string> |
| 26 | + |
| 27 | +//--------------------------------------------------------------------------- |
| 28 | + |
| 29 | + |
| 30 | +// Register this check class (by creating a static instance of it) |
| 31 | +namespace |
| 32 | +{ |
| 33 | +CheckPostfixOperator instance; |
| 34 | +} |
| 35 | + |
| 36 | +void CheckPostfixOperator::postfixOperator() |
| 37 | +{ |
| 38 | + if (!_settings->_checkCodingStyle) |
| 39 | + return; |
| 40 | + |
| 41 | + for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) |
| 42 | + { |
| 43 | + bool result = false; |
| 44 | + if ( Token::Match(tok, "++|--") ) { |
| 45 | + if ( Token::Match(tok->previous()->previous(), ";|{|}") && Token::Match(tok->next(), ";|)|,") ) { |
| 46 | + result = true; |
| 47 | + } |
| 48 | + else if (tok->strAt(-2) == ",") { |
| 49 | + unsigned int i(1); |
| 50 | + while(tok->strAt(i) != ")") { |
| 51 | + if(tok->strAt(i) == ";") { |
| 52 | + result = true; |
| 53 | + break; |
| 54 | + } |
| 55 | + ++i; |
| 56 | + } |
| 57 | + } |
| 58 | + else if (tok->strAt(-2) == "<<" && tok->strAt(1) == "<<") { |
| 59 | + result = true; |
| 60 | + } |
| 61 | + } |
| 62 | + |
| 63 | + if(result) { |
| 64 | + const Token *decltok = Token::findmatch(_tokenizer->tokens(), "%varid%", tok->previous()->varId()); |
| 65 | + if (decltok && Token::Match(decltok->previous(), "iterator|const_iterator|reverse_iterator|const_reverse_iterator")) { |
| 66 | + // the variable an iterator |
| 67 | + postfixOperatorError(tok); |
| 68 | + } |
| 69 | + else { |
| 70 | + const std::string classDef = std::string("class ") + std::string(decltok->previous()->strAt(0)); |
| 71 | + if (Token::findmatch(_tokenizer->tokens(), classDef.c_str())) { |
| 72 | + postfixOperatorError(tok); |
| 73 | + } |
| 74 | + } |
| 75 | + } |
| 76 | + } |
| 77 | +} |
| 78 | +//--------------------------------------------------------------------------- |
| 79 | + |
| 80 | + |
| 81 | +void CheckPostfixOperator::postfixOperatorError(const Token *tok) |
| 82 | +{ |
| 83 | + reportError(tok, Severity::style, "postfixOperator", "You should use ++ and -- as prefix whenever possible as these are more efficient than postfix operators"); |
| 84 | +} |
0 commit comments