enhance: remove FLUSH PRIVILEGES from the user managers FormShow handler. If a click on a non-flushed user in the tree produces an exception, that is caught and shown as a normal error message.

ansgarbecker · ansgarbecker · commit fe7a5ef97a80 · 2026-05-11T13:03:30.000+02:00
Refs #2479
diff --git a/source/usermanager.pas b/source/usermanager.pas
@@ -413,14 +413,6 @@ procedure TUserManagerForm.FormShow(Sender: TObject);
     tmp := FConnection.GetSessionVariable('skip_name_resolve');
     SkipNameResolve := LowerCase(tmp) = 'on';
 
-    try
-      FConnection.Query(qReloadPrivileges);
-    except
-      // FLUSH PRIVILEGE may fail due to missing RELOAD privilege.
-      // Proceed anyway, it's still ok to read/see the users
-      on E:EDbError do;
-    end;
-
     // Peek into user table structure, and find out where the password hash is stored
     UserTableColumns := FConnection.GetCol('SHOW COLUMNS FROM '+FConnection.QuoteIdent('mysql')+'.'+FConnection.QuoteIdent('user'));
     HasPassword := UserTableColumns.IndexOf('password') > -1;
