Memoize file match patterns (docker-java#1412)

swiedenfeld · bsideup · web-flow · commit c3661f3da85e · 2020-06-25T10:54:43.000+02:00
* Compile each file match pattern only once docker-java#1409 * Update GoLangFileMatch.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/GoLangFileMatch.java b/docker-java-core/src/main/java/com/github/dockerjava/core/GoLangFileMatch.java
@@ -6,8 +6,14 @@
 import java.io.File;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
 import java.util.regex.Pattern;
 
+import com.google.common.cache.CacheBuilder;
+import com.google.common.cache.CacheLoader;
+import com.google.common.cache.LoadingCache;
+import com.google.common.util.concurrent.UncheckedExecutionException;
 import org.apache.commons.lang.StringUtils;
 
 import com.github.dockerjava.core.exception.GoLangFileMatchException;
@@ -52,6 +58,11 @@ private GoLangFileMatch() {
 
     private static final String PATTERN_CHARS_TO_ESCAPE = "\\.[]{}()*+-?^$|";
 
+    private static final LoadingCache<String, Pattern> PATTERN_CACHE = CacheBuilder.newBuilder()
+        .expireAfterAccess(1, TimeUnit.HOURS)
+        .maximumSize(10_000)
+        .build(CacheLoader.from(GoLangFileMatch::buildPattern));
+
     public static boolean match(List<String> patterns, File file) {
         return !match(patterns, file.getPath()).isEmpty();
     }
@@ -74,7 +85,11 @@ public static List<String> match(List<String> patterns, String name) {
     }
 
     public static boolean match(String pattern, String name) {
-        return buildPattern(pattern).matcher(name).matches();
+        try {
+            return PATTERN_CACHE.get(pattern).matcher(name).matches();
+        } catch (ExecutionException | UncheckedExecutionException e) {
+            throw new GoLangFileMatchException(e.getCause().getMessage());
+        }
     }
 
     private static Pattern buildPattern(String pattern) {
