benchmark: support optional headers with wrk

sam-github · addaleax · commit f8e75512951b · 2020-02-06T15:22:49.000+01:00
wrk did not support sending optional headers, they were silently ignored. This appears to be an oversight, they were supported for autocannon. PR-URL: nodejs-private/node-private#189 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/benchmark/_http-benchmarkers.js b/benchmark/_http-benchmarkers.js
@@ -64,6 +64,9 @@ class WrkBenchmarker {
       '-t', 8,
       `http://127.0.0.1:${options.port}${options.path}`,
     ];
+    for (const field in options.headers) {
+      args.push('-H', `${field}: ${options.headers[field]}`);
+    }
     const child = child_process.spawn(this.executable, args);
     return child;
   }
