Skip to content

Commit 3cc3872

Browse files
Chan Chak ShingHainish
authored andcommitted
Update utils/merge-rulesets.py (EFForg#17492)
[Before] $ node --expose-gc utils/memusage.js Initial usage: 42.1 MB Maximum usage: 79.1 MB $ du -s rules/default.rulesets 6820 rules/default.rulesets [After] $ node --expose-gc utils/memusage.js Initial usage: 42 MB Maximum usage: 78.6 MB $ du -s rules/default.rulesets 6808 rules/default.rulesets
1 parent de97a00 commit 3cc3872

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

utils/merge-rulesets.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ def normalize(f):
4848
root = tree.getroot()
4949

5050
ruleset = {}
51+
trivialNameSecureCookie = None
5152

5253
for attr in root.attrib:
5354
ruleset[attr] = root.attrib[attr]
@@ -70,18 +71,29 @@ def normalize(f):
7071
ruleset["rule"].append(ru)
7172

7273
elif child.tag == "securecookie":
73-
sc = {}
74-
sc["host"] = child.attrib["host"]
75-
sc["name"] = child.attrib["name"]
74+
if child.attrib["name"] == ".+":
75+
if not trivialNameSecureCookie:
76+
trivialNameSecureCookie = {}
77+
trivialNameSecureCookie["host"] = child.attrib["host"]
78+
trivialNameSecureCookie["name"] = ".+"
79+
else:
80+
trivialNameSecureCookie["host"] = (trivialNameSecureCookie["host"] + "|" + child.attrib["host"])
81+
else:
82+
sc = {}
83+
sc["host"] = child.attrib["host"]
84+
sc["name"] = child.attrib["name"]
7685

77-
ruleset["securecookie"].append(sc)
86+
ruleset["securecookie"].append(sc)
7887

7988
elif child.tag == "exclusion":
8089
if len(ruleset["exclusion"]) == 0:
8190
ruleset["exclusion"].append(child.attrib["pattern"])
8291
else:
8392
ruleset["exclusion"][0] = (ruleset["exclusion"][0] + "|" + child.attrib["pattern"])
8493

94+
if trivialNameSecureCookie:
95+
ruleset["securecookie"].insert(0, trivialNameSecureCookie)
96+
8597
library.append(ruleset);
8698

8799
# Write to default.rulesets

0 commit comments

Comments
 (0)