Merge pull request iluwatar#384 from DevFactory/release/Redundant-Field-Initializer-fix-1

npathai · npathai · commit dfef28e93eb9 · 2016-02-18T12:39:06.000+05:30
pmd:RedundantFieldInitializer - Redundant-Field-Initializer
diff --git a/caching/src/main/java/com/iluwatar/caching/CacheStore.java b/caching/src/main/java/com/iluwatar/caching/CacheStore.java
@@ -31,7 +31,7 @@
  */
 public class CacheStore {
 
-  static LruCache cache = null;
+  static LruCache cache;
 
   private CacheStore() {
   }
diff --git a/caching/src/main/java/com/iluwatar/caching/LruCache.java b/caching/src/main/java/com/iluwatar/caching/LruCache.java
@@ -50,8 +50,8 @@ public Node(String userId, UserAccount userAccount) {
 
   int capacity;
   HashMap<String, Node> cache = new HashMap<>();
-  Node head = null;
-  Node end = null;
+  Node head;
+  Node end;
 
   public LruCache(int capacity) {
     this.capacity = capacity;
diff --git a/chain/src/main/java/com/iluwatar/chain/Request.java b/chain/src/main/java/com/iluwatar/chain/Request.java
@@ -44,7 +44,7 @@ public class Request {
    * Indicates if the request is handled or not. A request can only switch state from unhandled to
    * handled, there's no way to 'unhandle' a request
    */
-  private boolean handled = false;
+  private boolean handled;
 
   /**
    * Create a new request of the given type and accompanied description.
diff --git a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/DecoratingIterator.java b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/DecoratingIterator.java
@@ -32,7 +32,7 @@ public abstract class DecoratingIterator<TYPE> implements Iterator<TYPE> {
 
   protected final Iterator<TYPE> fromIterator;
 
-  private TYPE next = null;
+  private TYPE next;
 
   /**
    * Creates an iterator that decorates the given iterator.
diff --git a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java
@@ -111,7 +111,7 @@ public FluentIterable<TYPE> first(int count) {
       @Override
       public Iterator<TYPE> iterator() {
         return new DecoratingIterator<TYPE>(iterable.iterator()) {
-          int currentIndex = 0;
+          int currentIndex;
 
           @Override
           public TYPE computeNext() {
@@ -156,7 +156,7 @@ public Iterator<TYPE> iterator() {
           private int stopIndex;
           private int totalElementsCount;
           private List<TYPE> list;
-          private int currentIndex = 0;
+          private int currentIndex;
 
           @Override
           public TYPE computeNext() {
diff --git a/model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileLoader.java b/model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileLoader.java
@@ -37,7 +37,7 @@ public class FileLoader {
   /**
    * Indicates if the file is loaded or not.
    */
-  private boolean loaded = false;
+  private boolean loaded;
 
   /**
    * The name of the file that we want to load.
diff --git a/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java b/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java
@@ -35,8 +35,8 @@
 
 public class LoadBalancer {
   private static List<Server> servers = new ArrayList<>();
-  private static int id = 0;
-  private static int lastServedId = 0;
+  private static int id;
+  private static int lastServedId;
 
   static {
     servers.add(new Server("localhost", 8081, ++id));
diff --git a/producer-consumer/src/main/java/com/iluwatar/producer/consumer/Producer.java b/producer-consumer/src/main/java/com/iluwatar/producer/consumer/Producer.java
@@ -34,7 +34,7 @@ public class Producer {
 
   private final String name;
 
-  private int itemId = 0;
+  private int itemId;
 
   public Producer(String name, ItemQueue queue) {
     this.name = name;
diff --git a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java
@@ -40,7 +40,7 @@ public class ReaderWriterLock implements ReadWriteLock {
 
   private Object readerMutex = new Object();
 
-  private int currentReaderCount = 0;
+  private int currentReaderCount;
 
   /**
    * Global mutex is used to indicate that whether reader or writer gets the lock in the moment.
diff --git a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java
@@ -29,7 +29,7 @@
  */
 public class Writer implements Runnable {
 
-  private Lock writeLock = null;
+  private Lock writeLock;
 
   private String name;
 
diff --git a/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java b/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java
@@ -31,7 +31,7 @@
  */
 public final class ThreadSafeLazyLoadedIvoryTower {
 
-  private static ThreadSafeLazyLoadedIvoryTower instance = null;
+  private static ThreadSafeLazyLoadedIvoryTower instance;
 
   private ThreadSafeLazyLoadedIvoryTower() {}
 
diff --git a/twin/src/main/java/com/iluwatar/twin/BallItem.java b/twin/src/main/java/com/iluwatar/twin/BallItem.java
@@ -30,7 +30,7 @@
  */
 public class BallItem extends GameItem {
 
-  private boolean isSuspended = false;
+  private boolean isSuspended;
 
   private BallThread twin;
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`*/`
`32`	`32`	`public class CacheStore {`
`33`	`33`
`34`		`- static LruCache cache = null;`
	`34`	`+ static LruCache cache;`
`35`	`35`
`36`	`36`	`private CacheStore() {`
`37`	`37`	`}`