Skip to content

Commit 8d6bc52

Browse files
committed
Simplify lottery ticket submit
1 parent 266b658 commit 8d6bc52

File tree

4 files changed

+5
-175
lines changed

4 files changed

+5
-175
lines changed

hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,16 @@
2222
*/
2323
package com.iluwatar.hexagonal.domain;
2424

25+
import java.util.Optional;
26+
2527
/**
2628
*
2729
* Interface for submitting and checking lottery tickets.
2830
*
2931
*/
3032
public interface LotteryService {
3133

32-
LotteryTicketSubmitResult submitTicket(LotteryTicket ticket);
34+
Optional<LotteryTicketId> submitTicket(LotteryTicket ticket);
3335

3436
LotteryTicketCheckResult checkTicketForPrize(LotteryTicketId id, LotteryNumbers winningNumbers);
3537
}

hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryServiceImpl.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626

2727
import com.iluwatar.hexagonal.database.LotteryTicketRepositoryMock;
2828
import com.iluwatar.hexagonal.domain.LotteryTicketCheckResult.CheckResult;
29-
import com.iluwatar.hexagonal.domain.LotteryTicketSubmitResult.Result;
3029

3130
public class LotteryServiceImpl implements LotteryService {
3231

@@ -37,13 +36,8 @@ public LotteryServiceImpl() {
3736
}
3837

3938
@Override
40-
public LotteryTicketSubmitResult submitTicket(LotteryTicket ticket) {
41-
Optional<LotteryTicketId> optional = repository.save(ticket);
42-
Result result = Result.OK;
43-
if (!optional.isPresent()) {
44-
result = Result.ERROR;
45-
}
46-
return new LotteryTicketSubmitResult(result);
39+
public Optional<LotteryTicketId> submitTicket(LotteryTicket ticket) {
40+
return repository.save(ticket);
4741
}
4842

4943
@Override

hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryTicketSubmitResult.java

Lines changed: 0 additions & 115 deletions
This file was deleted.

hexagonal/src/test/java/com/iluwatar/hexagonal/domain/LotteryTicketSubmitResultTest.java

Lines changed: 0 additions & 51 deletions
This file was deleted.

0 commit comments

Comments
 (0)