Added tests for monostate pattern

fluxw42 · fluxw42 · commit 531158c83610 · 2015-12-21T13:29:25.000+01:00
diff --git a/monostate/pom.xml b/monostate/pom.xml
@@ -14,5 +14,10 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 </project>
diff --git a/monostate/src/main/java/com/iluwatar/monostate/App.java b/monostate/src/main/java/com/iluwatar/monostate/App.java
@@ -28,8 +28,8 @@ public class App {
   public static void main(String[] args) {
     LoadBalancer loadBalancer1 = new LoadBalancer();
     LoadBalancer loadBalancer2 = new LoadBalancer();
-    loadBalancer1.serverequest(new Request("Hello"));
-    loadBalancer2.serverequest(new Request("Hello World"));
+    loadBalancer1.serverRequest(new Request("Hello"));
+    loadBalancer2.serverRequest(new Request("Hello World"));
   }
 
 }
diff --git a/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java b/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java
@@ -39,7 +39,7 @@ public static int getLastServedId() {
     return lastServedId;
   }
 
-  public void serverequest(Request request) {
+  public void serverRequest(Request request) {
     if (lastServedId >= servers.size()) {
       lastServedId = 0;
     }
diff --git a/monostate/src/main/java/com/iluwatar/monostate/Server.java b/monostate/src/main/java/com/iluwatar/monostate/Server.java
@@ -25,7 +25,7 @@ public int getPort() {
     return port;
   }
 
-  public final void serve(Request request) {
+  public void serve(Request request) {
     System.out.println("Server ID " + id + " associated to host : " + getHost() + " and Port "
         + getPort() + " Processed request with value  " + request.value);
   }
diff --git a/monostate/src/test/java/com/iluwatar/monostate/AppTest.java b/monostate/src/test/java/com/iluwatar/monostate/AppTest.java
@@ -5,17 +5,6 @@
 
 public class AppTest {
 
-  @Test
-  public void testSameStateAmonstAllInstances() {
-    LoadBalancer balancer = new LoadBalancer();
-    LoadBalancer balancer2 = new LoadBalancer();
-    balancer.addServer(new Server("localhost", 8085, 6));
-    // Both should have the same number of servers.
-    Assert.assertTrue(balancer.getNoOfServers() == balancer2.getNoOfServers());
-    // Both Should have the same LastServedId
-    Assert.assertTrue(balancer.getLastServedId() == balancer2.getLastServedId());
-  }
-
   @Test
   public void testMain() {
     String[] args = {};
diff --git a/monostate/src/test/java/com/iluwatar/monostate/LoadBalancerTest.java b/monostate/src/test/java/com/iluwatar/monostate/LoadBalancerTest.java
@@ -0,0 +1,49 @@
+package com.iluwatar.monostate;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
+import static org.mockito.Mockito.verifyZeroInteractions;
+
+/**
+ * Date: 12/21/15 - 12:26 PM
+ *
+ * @author Jeroen Meulemeester
+ */
+public class LoadBalancerTest {
+
+  @Test
+  public void testSameStateAmongstAllInstances() {
+    final LoadBalancer firstBalancer = new LoadBalancer();
+    final LoadBalancer secondBalancer = new LoadBalancer();
+    firstBalancer.addServer(new Server("localhost", 8085, 6));
+    // Both should have the same number of servers.
+    Assert.assertTrue(firstBalancer.getNoOfServers() == secondBalancer.getNoOfServers());
+    // Both Should have the same LastServedId
+    Assert.assertTrue(firstBalancer.getLastServedId() == secondBalancer.getLastServedId());
+  }
+
+  @Test
+  public void testServe() {
+    final Server server = mock(Server.class);
+
+    final LoadBalancer loadBalancer = new LoadBalancer();
+    loadBalancer.addServer(server);
+
+    verifyZeroInteractions(server);
+
+    final Request request = new Request("test");
+    for (int i = 0; i < loadBalancer.getNoOfServers() * 2; i++) {
+      loadBalancer.serverRequest(request);
+    }
+
+    verify(server, times(2)).serve(request);
+    verifyNoMoreInteractions(server);
+
+  }
+
+}

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,8 @@ public class App {`
`28`	`28`	`public static void main(String[] args) {`
`29`	`29`	`LoadBalancer loadBalancer1 = new LoadBalancer();`
`30`	`30`	`LoadBalancer loadBalancer2 = new LoadBalancer();`
`31`		`- loadBalancer1.serverequest(new Request("Hello"));`
`32`		`- loadBalancer2.serverequest(new Request("Hello World"));`
	`31`	`+ loadBalancer1.serverRequest(new Request("Hello"));`
	`32`	`+ loadBalancer2.serverRequest(new Request("Hello World"));`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public static int getLastServedId() {`
`39`	`39`	`return lastServedId;`
`40`	`40`	`}`
`41`	`41`
`42`		`- public void serverequest(Request request) {`
	`42`	`+ public void serverRequest(Request request) {`
`43`	`43`	`if (lastServedId >= servers.size()) {`
`44`	`44`	`lastServedId = 0;`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public int getPort() {`
`25`	`25`	`return port;`
`26`	`26`	`}`
`27`	`27`
`28`		`- public final void serve(Request request) {`
	`28`	`+ public void serve(Request request) {`
`29`	`29`	`System.out.println("Server ID " + id + " associated to host : " + getHost() + " and Port "`
`30`	`30`	`+ getPort() + " Processed request with value " + request.value);`
`31`	`31`	`}`