Don't loop selection through all failed tests every time tests are run (#13000)

Kartik Raj · web-flow · commit b1e9031b1497 · 2020-07-16T12:17:28.000-07:00
diff --git a/news/2 Fixes/11743.md b/news/2 Fixes/11743.md
@@ -0,0 +1 @@
+Don't loop selection through all failed tests every time tests are run.
diff --git a/src/client/testing/explorer/treeView.ts b/src/client/testing/explorer/treeView.ts
@@ -40,6 +40,6 @@ export class TreeViewService implements IExtensionSingleActivationService, IDisp
         );
     }
     public async onRevealTestItem(testItem: TestDataItem): Promise<void> {
-        await this.treeView.reveal(testItem);
+        await this.treeView.reveal(testItem, { select: false });
     }
 }
diff --git a/src/test/testing/explorer/treeView.unit.test.ts b/src/test/testing/explorer/treeView.unit.test.ts
@@ -57,7 +57,7 @@ suite('Unit Tests Test Explorer Tree View', () => {
     test('Invoking the command handler will reveal the node in the tree', async () => {
         const data = {} as any;
         treeView
-            .setup((t) => t.reveal(typemoq.It.isAny()))
+            .setup((t) => t.reveal(typemoq.It.isAny(), { select: false }))
             .returns(() => Promise.resolve())
             .verifiable(typemoq.Times.once());
         when(appShell.createTreeView('python_tests', anything())).thenReturn(treeView.object);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Don't loop selection through all failed tests every time tests are run.`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,6 @@ export class TreeViewService implements IExtensionSingleActivationService, IDisp`
`40`	`40`	`);`
`41`	`41`	`}`
`42`	`42`	`public async onRevealTestItem(testItem: TestDataItem): Promise<void> {`
`43`		`- await this.treeView.reveal(testItem);`
	`43`	`+ await this.treeView.reveal(testItem, { select: false });`
`44`	`44`	`}`
`45`	`45`	`}`