feat(CI): Added check for manual tests checkbox#14263
Conversation
- Added GitHub Workflow that checks wether a user has performed a manual test.
There was a problem hiding this comment.
Code Review
This pull request updates the pull request template to recommend running local tests with Python 3.10 instead of Python 3.9. The reviewer recommends keeping the test command set to Python 3.9 to ensure compatibility with the minimum supported Python version and to prevent contributors from introducing incompatible Python 3.10+ features.
| - [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md) | ||
| - [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file) | ||
| - [ ] **Tests** pass: `nox -s py-3.9` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) | ||
| - [ ] **Tests** pass: `nox -s py-3.10` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) |
There was a problem hiding this comment.
According to the AUTHORING_GUIDE.md (line 112), Python 3.9 is still a supported version ("Samples should support Python 3.9, 3.10, 3.11, 3.12 and 3.13."). Changing the recommended local test command to py-3.10 might lead contributors to use Python 3.10+ features (such as the union operator | for types) that are incompatible with Python 3.9. It is safer to keep the test command as py-3.9 to ensure compatibility with the minimum supported version.
| - [ ] **Tests** pass: `nox -s py-3.10` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) | |
| - [ ] **Tests** pass: `nox -s py-3.9` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) |
dae7310 to
c44f868
Compare
Description
Fixes b/519321791
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)