Skip to content

Re-consider when to report to build-cop-bot #3821

Closed

Description

@tmatsuo

Currently we send the report in periodic builds.

if [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"periodic"* ]]; then
chmod +x $KOKORO_GFILE_DIR/linux_amd64/buildcop
$KOKORO_GFILE_DIR/linux_amd64/buildcop
fi

I think it is better to use more descriptive environment variable, say REPORT_TO_BUILD_COP_BOT or something and we can set that environment variable in our job configurations.

This way, we can have a flexibility of only sending build cop report from particular jobs (although I'm not planning to disable in any of our periodic builds), as well as manually run periodic builds without reporting to build-cop-bot (we can set environment variable when manually running the build).

Activity

  1. self-assigned this
    on May 19, 2020
  2. added a commit that references this issue on May 19, 2020
    415b4a2
  3. added a commit that references this issue on May 20, 2020
    64f6245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions