refactor(iam): Adding new iam_policytroublershooter region tag - Migration process 2/2 for troubleshooter_java_dependency#10278
Conversation
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/385748009
This PR is the Second part of the two PR process to rename the previous region tag, so it doesn't break the current devsite documentation. (Add new region tag -> Update devsite documentation -> New PR deleting old region tag)
The
troubleshooter_java_dependencyregion tag belongs to the primary product of Policy Troubleshooter (part of Policy Intelligence).The main reference to this region tag appears on the Google Cloud documentation at https://docs.cloud.google.com/policy-intelligence/docs/reference/libraries. It is documented under the Policy Troubleshooter API, which in all of the REST reference includes the
.iamreference. Furthermore, in thegoogle-cloud-javarepository, it references the Policy Troubleshooter API to the IAM product (https://github.com/googleapis/google-cloud-java/tree/main/java-policy-troubleshooter) using the same dependency referenced on the main and first Google doc here.Based on this, and considering the closest relation and use with IAM, the new prefix and name will be as follow
Region Tag Update
troubleshooter_java_dependencyiam_policytroubleshooter_java_dependencyThis includes the IAM product and adds the complete reference of the library on the region tag.
Impacted Documentation & References
.iamnamespace)iam/api-client/pom.xmlChecklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only