Conversation
busunkim96
reviewed
Jun 6, 2019
busunkim96
reviewed
Jun 6, 2019
plamut
reviewed
Jun 6, 2019
plamut
left a comment
Contributor
There was a problem hiding this comment.
LGTM. 👍
I tried overriding one of the timeout settings for a publisher through the client_config setting, and it worked. I also (correctly) got an error if an incorrect key was provided.
The rest of the comments on the original PR have been addressed, I only left a sanity check remark. If that is a non-concern, we are good to go IMO.
busunkim96
approved these changes
Jun 6, 2019
busunkim96
left a comment
Contributor
There was a problem hiding this comment.
Synth file looks good to me!
Contributor
|
Based on @busunkim96's comment, this seems to be good for merging. 👍 |
plamut
approved these changes
Jun 6, 2019
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
* Expose publish retry settings * remove backslashes * re-ran synthtool from HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #6641.
This PR updates the GAPIC publisher client using
synth.py.