Skip to content

Pub/Sub: surface publish future in documentation#8229

Merged
plamut merged 2 commits into
masterfrom
futures
Jun 6, 2019
Merged

Pub/Sub: surface publish future in documentation#8229
plamut merged 2 commits into
masterfrom
futures

Conversation

@anguillanneuf

@anguillanneuf anguillanneuf commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

This makes sure that the Publish Future documentation shows up here, and users can navigate to its own page.

@anguillanneuf anguillanneuf requested a review from busunkim96 as a code owner June 5, 2019 19:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2019
@anguillanneuf anguillanneuf added api: pubsub Issues related to the Pub/Sub API. type: docs Improvement to the documentation for an API. labels Jun 5, 2019
@anguillanneuf anguillanneuf requested a review from plamut June 5, 2019 21:51
@busunkim96 busunkim96 removed their request for review June 5, 2019 23:47

@plamut plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the docs locally and the publisher Future link is now indeed present under the "Publishing Messages" bullet point of the API Documentation section.

The docs for the publisher and subscriber futures also seem in order, approving. 👍

@plamut plamut merged commit cd57e65 into master Jun 6, 2019
@anguillanneuf anguillanneuf deleted the futures branch June 6, 2019 16:56
parthea pushed a commit that referenced this pull request Mar 2, 2026
* surface publish future in documentation

* Update class definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants