Skip to content

Pub/sub: pass transport w/ custom channel to GAPIC API clients.#7008

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:6887-pubsub-remove_channel_deprecation_warning
Jan 4, 2019
Merged

Pub/sub: pass transport w/ custom channel to GAPIC API clients.#7008
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:6887-pubsub-remove_channel_deprecation_warning

Conversation

@tseaver

@tseaver tseaver commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

Silences pending deprecation warnings for passing channel.

Closes #6887.

@tseaver tseaver added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Dec 19, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2018
@tseaver

tseaver commented Jan 3, 2019

Copy link
Copy Markdown
Contributor Author

@theacodes, @crwilcox Rebased against current master: PTAL.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@tseaver

tseaver commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

The bigtable failure is due to unblackened snippets: I just added #7048 to fix them.

The error reporting failure is due to #6987.

Silences pending deprecation warnings for passing channel.

Closes #6887.
@tseaver

tseaver commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

I've just rebased against the current master to try to isolate the non-pubsub failures.

@tseaver tseaver merged commit a28ef0d into googleapis:master Jan 4, 2019
@tseaver tseaver deleted the 6887-pubsub-remove_channel_deprecation_warning branch January 4, 2019 20:54
parthea pushed a commit that referenced this pull request Mar 2, 2026
Silences pending deprecation warnings for passing channel.

Closes #6887.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants